[GitHub] [hbase] bbeaudreault commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.
bbeaudreault commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1694256679 Thanks for making those changes. There are some warnings in the pre commit hooks (checkstyle, etc). Can you fix them? I'm going to be out of office until sept 5, so probably won't be able to re-review this until then. Just fyi, I'll get back to it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.
bbeaudreault commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1714564222 @zhuyaogai unit test failures look related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.
bbeaudreault commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1716206315 Test failure looks unrelated. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.
bbeaudreault commented on PR #5228: URL: https://github.com/apache/hbase/pull/5228#issuecomment-1716207454 @zhuyaogai thanks for all the work here! Can you submit a backport PR for branch-2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
