[GitHub] [hbase] bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration URL: https://github.com/apache/hbase/pull/1064#discussion_r369239072 ## File path: .idea/checkstyle-idea.xml ## @@ -0,0 +1,16 @@ + + + + + + + + + + + Review comment: > IRC, our POM is configured to ignore tests at the moment. Not totally sure about this. Here [1] is one instance where a test file is flagged by the checkstyle bot. [1] https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1039/2/artifact/out/diff-checkstyle-hbase-server.txt This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration URL: https://github.com/apache/hbase/pull/1064#discussion_r368198213 ## File path: .idea/checkstyle-idea.xml ## @@ -0,0 +1,16 @@ + + + + + + Review comment: Shouldn't we include the path for active configuration? Something like below, otherwise how does it hook up with our check style configuration? Something like below.. ``` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration URL: https://github.com/apache/hbase/pull/1064#discussion_r368198213 ## File path: .idea/checkstyle-idea.xml ## @@ -0,0 +1,16 @@ + + + + + + Review comment: Shouldn't we include the path for active configuration? Something like below, otherwise how does it hook up with our check style plugin? Something like below.. ``` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration
bharathv commented on a change in pull request #1064: HBASE-23707 Add IntelliJ check style plugin configuration URL: https://github.com/apache/hbase/pull/1064#discussion_r368198141 ## File path: .idea/checkstyle-idea.xml ## @@ -0,0 +1,16 @@ + + + + + + + + + + + Review comment: I think this should be "JavaOnlyWithTests".. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
