bharathv commented on a change in pull request #2555:
URL: https://github.com/apache/hbase/pull/2555#discussion_r509864934
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
##########
@@ -101,7 +107,7 @@
* Basic constructor that simply initializes values to reasonable defaults.
*/
public WALPrettyPrinter() {
- this(false, false, -1, new HashSet<String>(), null, null, false, false,
System.out);
+ this(false, false, -1, new HashSet<String>(), null, null, null, false,
false, System.out);
Review comment:
I think its time to use builder pattern for this, its getting annoyingly
long (perhaps in another patch).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
