[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-643884926 Thanks for all the comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-643076776 The ut failture on jdk8 seems not related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-642585212 Ping @wchevreuil @virajjasani This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-639968883 @virajjasani @wchevreuil Could you help to review it, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638587744 Posted a screenshot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638549983 The mvninstall failture ofmaster seems not related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638122516 @wchevreuil Sorry for the delay, since it remove the checkbox and use tabs in latest version, i add a new tab named Localities, including two metrics Locality and LocalityForSsd. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-621150790 > Is it possible to display this metric only when SSD is in use, or would extra checks be too complicated? I guess most of the time it won't, so the extra metric being shown may not be relevant and cause confusion. How about add a checkbox for it ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-619542169 rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org