[GitHub] [hbase] busbey commented on a change in pull request #2180: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe
busbey commented on a change in pull request #2180: URL: https://github.com/apache/hbase/pull/2180#discussion_r464027188 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java ## @@ -69,7 +69,7 @@ Compression.Algorithm.NONE, Compression.Algorithm.GZ }; - protected Configuration conf; + protected final Configuration conf; Review comment: we make use of this across our internal subclasses of `HBaseCommonTestingUtility` so if we made it private instead of protected we'd need to add an accessor. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #2180: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe
busbey commented on a change in pull request #2180: URL: https://github.com/apache/hbase/pull/2180#discussion_r463650086 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java ## @@ -69,7 +69,7 @@ Compression.Algorithm.NONE, Compression.Algorithm.GZ }; - protected Configuration conf; + protected final Configuration conf; Review comment: s/hbase client code/code that uses hbase client This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #2180: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe
busbey commented on a change in pull request #2180: URL: https://github.com/apache/hbase/pull/2180#discussion_r463649812 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java ## @@ -69,7 +69,7 @@ Compression.Algorithm.NONE, Compression.Algorithm.GZ }; - protected Configuration conf; + protected final Configuration conf; Review comment: > should it be changed to IA Private here? no, there 's a whole back and forth community discussion that has been on-going in bits and pieces for years. the short version is that we definitely need something downstream facing for running tests of hbase client code, but no one has provided a clean way to separate that out from how we test our own stuff. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #2180: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe
busbey commented on a change in pull request #2180: URL: https://github.com/apache/hbase/pull/2180#discussion_r463454640 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java ## @@ -69,7 +69,7 @@ Compression.Algorithm.NONE, Compression.Algorithm.GZ }; - protected Configuration conf; + protected final Configuration conf; Review comment: Changing this variable to final break binary compatibility, but is needed to make access to this field threadsafe. I could maintain binary compatibility by making a _new_ final variable called "originalConf" or something like that which is used by our own internals. but that would still cause a behavior change because if someone made a subclass of these classes that assigned to the `conf` variable we would not pay any attention to that change. I think we should just release note the break, especially given the on-going issue of "should we be labeling these things IA.Public yet?" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on a change in pull request #2180: HBASE-24805 HBaseTestingUtility.getConnection should be threadsafe
busbey commented on a change in pull request #2180: URL: https://github.com/apache/hbase/pull/2180#discussion_r463454640 ## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java ## @@ -69,7 +69,7 @@ Compression.Algorithm.NONE, Compression.Algorithm.GZ }; - protected Configuration conf; + protected final Configuration conf; Review comment: Changing this variable to final breaks binary compatibility, but is needed to make access to this field threadsafe. I could maintain binary compatibility by making a _new_ final variable called "originalConf" or something like that which is used by our own internals. but that would still cause a behavior change because if someone made a subclass of these classes that assigned to the `conf` variable we would not pay any attention to that change. I think we should just release note the break, especially given the on-going issue of "should we be labeling these things IA.Public yet?" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
