[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-564651031 @joshelser you self-resolved all your concerns, does that mean you're +1? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB
files from client-facing cells
URL: https://github.com/apache/hbase/pull/785#issuecomment-564124892
these three checkstyle things are new and I'll push a fix for them shortly.
```
./hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java:160:
* * MISSING FILE BUT FAILURE WHILE CHECKING HLINKS - We could not find the
referenced file, however: Line is longer than 100 characters (found 102).
[LineLength]
./hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java:225:
final Text INCONSISTENT_ARCHIVE_BAD_LINK = new Text("ARCHIVE WITH HLINK BUT
NOT FROM OUR TABLE");: Line is longer than 100 characters (found 101).
[LineLength]
./hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java:355:
LOG.error("Exception while checking mob area of our table for
HFileLinks that point to {}",: Line is longer than 100 characters (found 101).
[LineLength]
```
the other two are the previously mentioned example report output.
> whitespace | 0m 0s | The patch 2 line(s) with tabs.
these are example report output, so I think the tabs should be left in place.
```
[ERROR] Failures:
[ERROR]
TestReplicationEndpointWithMultipleAsyncWAL>TestReplicationEndpoint.testInterClusterReplication:235
Waiting timed out after [30,000] msec Failed to replicate all edits, expected
= 2500 replicated = 2467
[WARNING] Flakes:
[WARNING]
org.apache.hadoop.hbase.namespace.TestNamespaceAuditor.testRegionMerge(org.apache.hadoop.hbase.namespace.TestNamespaceAuditor)
[ERROR] Run 1: TestNamespaceAuditor.testRegionMerge:387 » Timeout
[INFO] Run 2: PASS
```
these failures in the unit tests are not related AFAICT.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-564123243 have time to take another look @cbaenziger ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-563892911 this last commit implements some feedback I got from someone in our support organization. essentially, they suggested I make sure each individual line about sizes was a clear stand alone statement to minimize the chances that someone would misinterpret the numbers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-562684751 again, rebase to current master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-556510248 that push was just rebasing to current master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-550541151 > Failed junit tests | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure as far as I can tell this unit test failure is unrelated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-550540948 Checkstyle complaints > ./hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java:125: * RESULT OF LOOKUP FILE REFcomma seperated, base64 encoded rows when there's a problem:20: File contains tab characters (this is the first instance). [FileTabCharacter] > ./hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java:132: * MISSING FILE 28e252d7f013973174750d483d358fa020191101f73536e7133f4cd3ab1065edf588d509 MmJiMjMyYzBiMTNjNzc0OTY1ZWY4NTU4ZjBmYmQ2MTUtNTIz,MmEzOGE0YTkzMTZjNDllNWE4MzM1MTdjNDVkMzEwNzAtODg=: Line is longer than 100 characters (found 196). [LineLength] Whitespace complaints > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java:125: * RESULT OF LOOKUPFILE REFcomma seperated, base64 encoded rows when there's a problem > hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java:131: * MOB DIR 09c576e28a65ed2ead0004d192ffaa382019110184b30a1c7e034573bf8580aef8393402 These are all literal examples of the report output. I'd like to keep them accurate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-550202178 * rebased to current master. * addressed qabot feedback (with the exception of not changing the example output) * addressed most of @cbaenziger 's feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells
busbey commented on issue #785: HBASE-23239 Reporting on status of backing MOB files from client-facing cells URL: https://github.com/apache/hbase/pull/785#issuecomment-549089052 > whitespace | 0m 0s | The patch 2 line(s) with tabs. ``` hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java:127: * RESULT OF LOOKUP FILE REFcomma seperated, base64 encoded rows when there's a problem hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/MobRefReporter.java:133: * MOB DIR 09c576e28a65ed2ead0004d192ffaa382019110184b30a1c7e034573bf8580aef8393402 ``` these are examples of report output that contains tabs, so I'd rather leave them for accuracy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
