[GitHub] [hbase] busbey commented on pull request #2172: HBASE-24795 : RegionMover to deal with unknown region while (un)loading

2020-07-30 Thread GitBox 


busbey commented on pull request #2172:
URL: https://github.com/apache/hbase/pull/2172#issuecomment-666521173


   is there a particular reason we're conflating formatting changes here?
   
   are the qa failures related?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] busbey commented on pull request #2172: HBASE-24795 : RegionMover to deal with unknown region while (un)loading

2020-07-30 Thread GitBox 


busbey commented on pull request #2172:
URL: https://github.com/apache/hbase/pull/2172#issuecomment-666528956


   > I just thought of refactoring MoveWithAck and MoveWithoutAck as high level 
classes since RegionMover is quite huge.
   
   that's a good idea; please make sure there is a note about that in the 
commit message body.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] busbey commented on pull request #2172: HBASE-24795 : RegionMover to deal with unknown region while (un)loading

2020-07-31 Thread GitBox 


busbey commented on pull request #2172:
URL: https://github.com/apache/hbase/pull/2172#issuecomment-667169370


   > Precommit run is not getting scheduled, waiting logs are present for long 
time
   
   it's backlog waiting for executors to open up on the new ci host:
   
   https://ci-hadoop.apache.org/label/Hadoop/load-statistics
   
   looks like the queue size started to climb yesterday around midnight. peaked 
about 5 hours ago at ~300. is now sitting around 280.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org