busbey opened a new pull request #4018: URL: https://github.com/apache/hbase/pull/4018
For previous discussion see HBASE-26469 and the draft PR #3901 Based on those discussions, this patch * refactors how we handle running the passed in initialization script to make use of IRB sessions directly instead of reimplementing things ourselves * simplify how we initialize our IRB config * insert a shim for capturing exit codes passed via user calls to `exit` * make use of user provided exit code unless we're reading stdin in interactive mode for comparison to previously provided summaries of return codes, this patch results in: | | clean exit code | error exit code | |------------|----------------|---------------| | cli, default | 0 | 1 | | cli, -n | 0 | 1 | | stdin, default | 0 | 0 | | stdin, -n | 0 | 1 | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org