clarax edited a comment on pull request #3729: URL: https://github.com/apache/hbase/pull/3729#issuecomment-938019981
> The problem has been described nicely on jira, but looking at the code, I haven't gotten the point on how to fix the problem... > > Mind explaining a bit about the new algorithm? > > And on reservoir sampling, I've implemented a util class recently, it is `org.apache.hadoop.hbase.util.ReservoirSample`, it is in hbase-common module, you can see if you can make use of it directly. > > Thanks. Sorry I think I mixed up the commits for HBASE-26309 and HBASE-26327 on this branch. Please review on the other PR for the algorithm. https://github.com/apache/hbase/pull/3723. The summary of problem and fixes is posted at https://docs.google.com/document/d/1ELcFlXkF4q7x-ZfPd9vGkz8RCSw2oRbL-yMp8ANW2Rs/edit#heading=h.v8fhroxb12gn I will take a look at the utility too. For this PR, I will clean up the branch and push again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
