[GitHub] [hbase] cuibo01 commented on pull request #2690: HBASE-24395 Backport HBASE-20589 to branch-1

2021-01-13 Thread GitBox


cuibo01 commented on pull request #2690:
URL: https://github.com/apache/hbase/pull/2690#issuecomment-759861104


   @saintstack @pankaj72981  pls review,and merge. thx



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] cuibo01 commented on pull request #2690: HBASE-24395 backport HBASE-20589

2020-11-23 Thread GitBox


cuibo01 commented on pull request #2690:
URL: https://github.com/apache/hbase/pull/2690#issuecomment-732007508


   HBASE-19200 Make hbase-client only depend on ZKAsyncRegistry and ZNod…
   because 2.x and 1.x connection are the different,so testStopActiveMaster 
failed.
   
   >2.x  ServerName oldMetaServer = 
conn.locateRegions(TableName.META_TABLE_NAME).get(0).getServerName();
   
   >1.x ServerName oldMetaServer = 
conn.locateRegion(HRegionInfo.FIRST_META_REGIONINFO
   .getRegionName()).getServerName();



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] cuibo01 commented on pull request #2690: HBASE-24395 backport HBASE-20589

2020-11-21 Thread GitBox


cuibo01 commented on pull request #2690:
URL: https://github.com/apache/hbase/pull/2690#issuecomment-731706228


   
![image](https://user-images.githubusercontent.com/36881649/99896840-3e4cb900-2ccf-11eb-83fb-222fd85f85d6.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org