[GitHub] [hbase] infraio commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-28 Thread GitBox


infraio commented on pull request #2579:
URL: https://github.com/apache/hbase/pull/2579#issuecomment-717856156


   > @ddupg Need to fix the spotbugs warnings: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2579/5/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
   
   The spotbugs warnings is about HBASE-24666, not about this PR. And this PR 
fixed thems. "hbase-server generated 0 new + 0 unchanged - 3 fixed = 0 total 
(was 3)"



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] infraio commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-27 Thread GitBox


infraio commented on pull request #2579:
URL: https://github.com/apache/hbase/pull/2579#issuecomment-717610489


   @ddupg Need to fix the spotbugs warnings: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2579/5/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] infraio commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox


infraio commented on pull request #2579:
URL: https://github.com/apache/hbase/pull/2579#issuecomment-716902255


   > Thanks @infraio for reviewing. I have fixed as comments.
   > 
   > > Add master UI to show ReplicationServer?
   > 
   > Do it in this PR? I was going to do it in a new PR?
   
   Ok. Can be done in follow-on PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] infraio commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-25 Thread GitBox


infraio commented on pull request #2579:
URL: https://github.com/apache/hbase/pull/2579#issuecomment-716337940


   Add master UI to show ReplicationServer?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org