[GitHub] [hbase] joshelser commented on issue #476: HBASE-11062 hbtop
joshelser commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-527484805 > Regarding the issue where the byte-sizes don't get rolled up to the next unit, I added a logic to do it in FieldValue Looks good! > I made Record class immutable in the latest commit. Left a new comment (throw UnsupportedOperationException instead of letting it throw an exception via the `ImmutableMap`), but that doesn't need to block getting this in. If we think this is ready to go, I'll test it locally again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on issue #476: HBASE-11062 hbtop
joshelser commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-524937951 Worked flawlessly for me on `master`. One question I haven't been able to find the answer to on my own yet: when do byte-sizes get rolled up to the next unit? (e.g. MB to GB) I see my storefile size is still reporting `13818.0MB`. I feel like at this point `13.8GB` is sufficient for what I care about, but I'm not sure if this is unique to your code, or just something else in HBase you're re-using. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on issue #476: HBASE-11062 hbtop
joshelser commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-524861217 +1 to the idea of stabilizing things well enough that hbtop can live outside of HBase (need to look at interface-stability things for what it's using), but agree with Stack that starting in "core" is fine. I got to listen to Toshi (and Dice) talk about this in person and I was blown away. My only regret is taking so long to unwind my queue and give a review up here :) I'm sifting through this now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
