ndimiduk commented on code in PR #4716:
URL: https://github.com/apache/hbase/pull/4716#discussion_r952753036
##
dev-support/create-release/README.txt:
##
@@ -105,6 +105,9 @@ $ scp ~/gpg.example.apache.pub example.gce.host:
# gpg-agent's extra socket (this will restrict what commands the remote node
is allowed to have
# your agent handle. Note that the gpg guide above can help you set this up
in your ssh config
# rather than typing it in ssh like this every time.
+# Note that as of maven-gpg-plugin, with gnupg >= 2.1, the plugin uses
`--pinentry-mode error`,
Review Comment:
Yeah, lets see if we add a launch flag like Duo suggests. I'll update the
readme accordingly.
##
dev-support/create-release/release-util.sh:
##
@@ -30,7 +30,7 @@
DRY_RUN=${DRY_RUN:-1} #default to dry run
DEBUG=${DEBUG:-0}
GPG=${GPG:-gpg}
-GPG_ARGS=(--no-autostart --batch)
+GPG_ARGS=(-v --no-autostart --batch --pinentry-mode error)
Review Comment:
I can leave out the `-v`, but the `--pinentry-mode error` is how the
maven-gpg-plugin invokes the command. It'll error out rather than giving the
user a prompt from pin entry. So, it checks that the socket works, but it will
fail if the user has not unlocked the key before starting the build. Maybe we
keep this but add another test invocation run from the host environment, in
non-`batch` and allow for pin entry?
##
dev-support/create-release/release-util.sh:
##
@@ -639,10 +639,16 @@ make_binary_release() {
# a third to assemble the binary artifact. Trying to do
# all in the one invocation fails; a problem in our
# assembly spec to in maven. TODO. Meantime, three invocations.
- "${MVN[@]}" clean install -DskipTests
- "${MVN[@]}" site -DskipTests
+ cmd=("${MVN[@]}" clean install -DskipTests)
+ echo "${cmd[*]}"
+ "${cmd[@]}"
+ cmd=("${MVN[@]}" site -DskipTests)
+ echo "${cmd[*]}"
+ "${cmd[@]}"
kick_gpg_agent
- "${MVN[@]}" install assembly:single -DskipTests -Dcheckstyle.skip=true
"${PUBLISH_PROFILES[@]}"
+ cmd=("${MVN[@]}" install assembly:single -DskipTests -Dcheckstyle.skip=true
"${PUBLISH_PROFILES[@]}")
+ echo "${cmd[*]}"
+ "${cmd[@]}"
Review Comment:
Not needed but helpful when reading logs. Without this, I can't tell which
step is ending in failure. I'm fine with pulling them out to a separate PR if
you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
