[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox


ndimiduk commented on pull request #2490:
URL: https://github.com/apache/hbase/pull/2490#issuecomment-713876958


   Rebased.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-21 Thread GitBox


ndimiduk commented on pull request #2490:
URL: https://github.com/apache/hbase/pull/2490#issuecomment-713813965


   Bump.
   
   The last build-bot run was all greens, I'm not sure why the GitHub status 
didn't update.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-12 Thread GitBox


ndimiduk commented on pull request #2490:
URL: https://github.com/apache/hbase/pull/2490#issuecomment-707393565


   Rebase and address checkstyle nits.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-09 Thread GitBox


ndimiduk commented on pull request #2490:
URL: https://github.com/apache/hbase/pull/2490#issuecomment-706296345


   Left some additional notes for reviewers.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-09 Thread GitBox


ndimiduk commented on pull request #2490:
URL: https://github.com/apache/hbase/pull/2490#issuecomment-706293211


   Now that HBASE-24628/#2454 is merged, this should be easier to review. 
Rebased.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox


ndimiduk commented on pull request #2490:
URL: https://github.com/apache/hbase/pull/2490#issuecomment-703952605


   > How they relate @ndimiduk ? Should this be closed? I can move over but 
seems like you getting good review there. Saw this and saw it lonely so started 
in
   
   From the description of this pr:
   
   > Pay mind only to the commit for this JIRA. This PR depends on 
HBASE-24628/#2454 and will need rebased once that one lands.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] ndimiduk commented on pull request #2490: HBASE-24419 Normalizer merge plans should consider more than 2 regions when possible

2020-10-05 Thread GitBox


ndimiduk commented on pull request #2490:
URL: https://github.com/apache/hbase/pull/2490#issuecomment-703930337


   Hey @saintstack most of your comments here should be over on #2454 , where 
the refactoring happened.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org