[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1057037823 Thanks for getting us started, @madrob ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1057037578 Resolved via #4133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1010538498 Also, the checkstyle violation reported by the build bot is valid, https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3979/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1010536953 @madrob I applied this patch but reverted your changes to `hbase-build-configuration/pom.xml`. I then reproduced the ErrorProne violation from #3968. The upgraded version of ErrorProne fails with a meaningful error message. Which means, the upgrade here does fix the the pre-commit issue I saw over there. ``` [ERROR] /Users/ndimiduk/repos/apache/hbase/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java:[1604,50] error: [RestrictedApi] Should only be called in self or ZKUtil ``` Please revert the change to `hbase-build-configuration/pom.xml`, keeping ErrorProne configured for JDK8, and you have my +1 on this change. If you want me to take it over, let me know. Thanks for the drive-by đź‘Ť -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1005299061 > Yes, the latest version doesn’t work with java 8. Still should fix the other bugs tho Per my read of https://errorprone.info/docs/installation#jdk-8, 2.10.0 is the last version with support for JDK8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3979: HBASE-26622 Update error-prone to 2.10
ndimiduk commented on pull request #3979: URL: https://github.com/apache/hbase/pull/3979#issuecomment-1005298249 > Maybe we could change the pre commit compile stage to use java11 with --release=8? Doesn't work, #3974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
