[GitHub] [hbase] nyl3532016 commented on a change in pull request #3191: HBASE-25757 Move BaseLoadBalancer to hbase-balancer module

2021-04-26 Thread GitBox 


nyl3532016 commented on a change in pull request #3191:
URL: https://github.com/apache/hbase/pull/3191#discussion_r619737005



##
File path: 
hbase-balancer/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodesPlan.java
##
@@ -75,7 +75,7 @@ public void updateFavoredNodesMap(RegionInfo region, 
List servers) {
   }
 
   /**
-   * @return the list of favored region server for this region based on the 
plan
+   * Returns the list of favored region server for this region based on the 
plan

Review comment:
   we do not use javadoc ?

##
File path: 
hbase-balancer/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodesPlan.java
##
@@ -75,7 +75,7 @@ public void updateFavoredNodesMap(RegionInfo region, 
List servers) {
   }
 
   /**
-   * @return the list of favored region server for this region based on the 
plan
+   * Returns the list of favored region server for this region based on the 
plan

Review comment:
   Get it, Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3191: HBASE-25757 Move BaseLoadBalancer to hbase-balancer module

2021-04-24 Thread GitBox 


nyl3532016 commented on a change in pull request #3191:
URL: https://github.com/apache/hbase/pull/3191#discussion_r619743370



##
File path: 
hbase-balancer/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodesPlan.java
##
@@ -75,7 +75,7 @@ public void updateFavoredNodesMap(RegionInfo region, 
List servers) {
   }
 
   /**
-   * @return the list of favored region server for this region based on the 
plan
+   * Returns the list of favored region server for this region based on the 
plan

Review comment:
   Get it, Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3191: HBASE-25757 Move BaseLoadBalancer to hbase-balancer module

2021-04-24 Thread GitBox 


nyl3532016 commented on a change in pull request #3191:
URL: https://github.com/apache/hbase/pull/3191#discussion_r619737005



##
File path: 
hbase-balancer/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodesPlan.java
##
@@ -75,7 +75,7 @@ public void updateFavoredNodesMap(RegionInfo region, 
List servers) {
   }
 
   /**
-   * @return the list of favored region server for this region based on the 
plan
+   * Returns the list of favored region server for this region based on the 
plan

Review comment:
   we do not use javadoc ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org