[GitHub] [hbase] ragarkar commented on a diff in pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

[via GitHub]

ragarkar commented on code in PR #5376:
URL: https://github.com/apache/hbase/pull/5376#discussion_r1310267557


##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##
@@ -1477,6 +1477,7 @@ private void disableCache() {
   // If persistent ioengine and a path, we will serialize out the 
backingMap.
   this.backingMap.clear();
   this.fullyCachedFiles.clear();
+  this.regionCachedSizeMap.clear();

Review Comment:
   Done. Added code to clear the regionCachedSizeMap



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] ragarkar commented on a diff in pull request #5376: HBASE-27999 Implement cache prefetch aware load balancer

[via GitHub]

ragarkar commented on code in PR #5376:
URL: https://github.com/apache/hbase/pull/5376#discussion_r1310115419


##
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java:
##
@@ -2906,6 +2907,25 @@ public boolean ensureSomeRegionServersAvailable(final 
int num) throws IOExceptio
 return startedServer;
   }
 
+  /**
+   * Waits for all the regions of a table to be prefetched fully
+   * @param table Table to be wait on.
+   */

Review Comment:
   Removed these functions as they are not needed. I had written them for a 
test, but that test is not included in the current patch as I still need to 
work on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org