[GitHub] [hbase] saintstack commented on a change in pull request #1048: HBASE-23694 After RegionProcedureStore completes migration of WALProcedureStore, …

2020-01-17 Thread GitBox 
saintstack commented on a change in pull request #1048: HBASE-23694 After 
RegionProcedureStore completes migration of WALProcedureStore, …
URL: https://github.com/apache/hbase/pull/1048#discussion_r368051343
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
 ##
 @@ -364,6 +364,7 @@ public void handleCorrupted(ProcedureIterator procIter) 
throws IOException {
   throw new IOException("Failed to delete the WALProcedureStore migrated 
proc wal directory " +
 procWALDir);
 }
+store.stop(true);
 
 Review comment:
   Ok. Good enough for now. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] saintstack commented on a change in pull request #1048: HBASE-23694 After RegionProcedureStore completes migration of WALProcedureStore, …

2020-01-15 Thread GitBox 
saintstack commented on a change in pull request #1048: HBASE-23694 After 
RegionProcedureStore completes migration of WALProcedureStore, …
URL: https://github.com/apache/hbase/pull/1048#discussion_r367102648
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
 ##
 @@ -364,6 +364,7 @@ public void handleCorrupted(ProcedureIterator procIter) 
throws IOException {
   throw new IOException("Failed to delete the WALProcedureStore migrated 
proc wal directory " +
 procWALDir);
 }
+store.stop(true);
 
 Review comment:
   Why an abort and  not non-abort here? Should this be in finally block? I 
closed my dupe of this over in HBASE-23696


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services