[GitHub] [hbase] saintstack commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-30 Thread GitBox


saintstack commented on pull request #1814:
URL: https://github.com/apache/hbase/pull/1814#issuecomment-636419167


   @mmpataki  We have flakey tests.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [hbase] saintstack commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-05-31 Thread GitBox


saintstack commented on pull request #1814:
URL: https://github.com/apache/hbase/pull/1814#issuecomment-636519732


   Sorry you didn't response on mailing list.
   
   Yeah, i think it should be optional opt-in. We publish metrics on the 
/metrics servlet, we then also publish to jmx, we also ship metrics over the 
heartbeat to the master. Each formatting takes up resources -- mem, cpu -- so 
unless the prometheus custom interface is being consumed, lets not have the 
general service pay the price.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org