[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510#issuecomment-613768194 @enis Hi, could you help me to review this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510#issuecomment-613768352 The findbugs warning seems unrelated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty
when just use simple acl but not use authentication
URL: https://github.com/apache/hbase/pull/1510#issuecomment-613776774
The code in AccessController.preListSnapshot:
`if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) {
// list it, if user is the owner of snapshot
AuthResult result = AuthResult.allow("listSnapshot " +
snapshot.getName(),
"Snapshot owner check allowed", user, null, null, null);
accessChecker.logResult(result);
}`
So i think the logic of setOwner is used for **authorization**, not
**authentication**, SnapshotManager should not only setOwner when
`hbase.security.authentication = kerberos`, which cause listSnapshots returns
empty when i just use simple acls.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510#issuecomment-614543028 @saintstack hi, could you help me to review this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication
thangTang commented on issue #1510: HBASE-24184 listSnapshots returns empty when just use simple acl but not use authentication URL: https://github.com/apache/hbase/pull/1510#issuecomment-614545281 @infraio hi, could you help me to review this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
