[GitHub] [hbase] ujjawal4046 commented on pull request #4754: HBASE-27352 - Quoted string argument with spaces passed from command line are propagated wrongly to the underlying java class

2022-09-13 Thread GitBox


ujjawal4046 commented on PR #4754:
URL: https://github.com/apache/hbase/pull/4754#issuecomment-1245341264

   @ndimiduk Sorry, looks like my work ID got attached. Have updated it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] ujjawal4046 commented on pull request #4754: HBASE-27352 - Quoted string argument with spaces passed from command line are propagated wrongly to the underlying java class

2022-09-13 Thread GitBox


ujjawal4046 commented on PR #4754:
URL: https://github.com/apache/hbase/pull/4754#issuecomment-1245322927

   > I looked back through the history on the original PR and don't see a 
reason why I used read instead of a simpler construct... You did some testing 
after this change?
   
   Yes, I had tested it manually after doing this change to ensure command line 
args are passed as it is from script to the underlying java class (for e.g. 
Import job). @ndimiduk Can you merge this if it looks okay ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase] ujjawal4046 commented on pull request #4754: HBASE-27352 - Quoted string argument with spaces passed from command line are propagated wrongly to the underlying java class

2022-08-31 Thread GitBox


ujjawal4046 commented on PR #4754:
URL: https://github.com/apache/hbase/pull/4754#issuecomment-1233249042

   @ndimiduk Can you take a look whenever you get a chance, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org