[GitHub] [hbase] virajjasani commented on a change in pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

[GitBox]

virajjasani commented on a change in pull request #2241:
URL: https://github.com/apache/hbase/pull/2241#discussion_r469198506



##
File path: hbase-shell/src/main/ruby/shell/commands/unassign.rb
##
@@ -22,8 +22,10 @@ module Commands
 class Unassign < Command
   def help
 <<-EOF
-Unassign a region. Unassign will close region in current location and then
-reopen it again.  Pass 'true' to force the unassignment ('force' will clear
+Unassign a region. It could be executed only when region in expected 
state(OPEN).
+In addition, you can use "unassigns" which supported by hbck2 to skip the 
state check.
+See 
https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/README.md
 for more info.

Review comment:
   And also, we can keep link in bracket like `(For more info on HBCK2: 
https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/README.md)`

##
File path: hbase-shell/src/main/ruby/shell/commands/unassign.rb
##
@@ -22,8 +22,10 @@ module Commands
 class Unassign < Command
   def help
 <<-EOF
-Unassign a region. Unassign will close region in current location and then
-reopen it again.  Pass 'true' to force the unassignment ('force' will clear
+Unassign a region. It could be executed only when region in expected 
state(OPEN).
+In addition, you can use "unassigns" which supported by hbck2 to skip the 
state check.
+See 
https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/README.md
 for more info.

Review comment:
   I think we can write this at the end similar to above `assign.rb` (above 
Examples)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] virajjasani commented on a change in pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

[GitBox]

virajjasani commented on a change in pull request #2241:
URL: https://github.com/apache/hbase/pull/2241#discussion_r469152741



##
File path: hbase-shell/src/main/ruby/shell/commands/assign.rb
##
@@ -22,8 +22,8 @@ module Commands
 class Assign < Command
   def help
 <<-EOF
-Assign a region. Use with caution. If region already assigned,
-this command will do a force reassign. For experts only.
+Assign a region. It could be executed only when region in expected 
state(CLOSED, OFFLINE).

Review comment:
   Is this right place to provide doc reference links? If so, we can 
provide link to HBCK2 command doc: 
https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/README.md





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org