[GitHub] [hbase] virajjasani commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread
virajjasani commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-670949728 Do you think using default UncaughtExceptionHandler will provide better warn logs if something goes wrong with relogin()? Maybe try creating a custom UncaughtExceptionHandler with `NettyRpcConnection` specific log message so that it is easier to figure out the issue runtime? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread
virajjasani commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-670949206 > @virajjasani when submitting this patch, I find maybe the default UncaughtExceptionHandler (Threads.LOGGING_EXCEPTION_HANDLER) will unset in ThreadFactoryBuilder.dobuild after HBASE-24750, It will be an Inconsistent ? We are not planning to remove `Threads.LOGGING_EXCEPTION_HANDLER`, it will stay. I hope the expectation for this patch is to handle the exception and just log it, and to not propagate it back to caller. If so, using this default UncaughtExceptionHandler from Threads class is fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
