[GitHub] [hbase] virajjasani commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-09-03 Thread GitBox 


virajjasani commented on pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#issuecomment-686667507


   I am considering to use the same filter based approach I did for the slow 
log method in Admin.java, where a `LogEntryFilter` can express a limit.
   `LogEntryFilter` expresses "limit" for slow/large log and similarly 
`BalancerDecisionRequest` expresses "limit" for balancerDecision.
   Both have built-in "limit" values and user can change it, but without 
constructing LogEntryFilter/BalancerDecisionRequest objects, user can not even 
invoke Admin.getLogEntries API. So either default or user provided "limit" will 
definitely reach to Admin.getLogEntries().
   
   ```
   1.
   public class BalancerDecisionRequest extends LogRequest {
   ...
 private int limit = 250;
   ...
   ...
   
   2.
   public class LogQueryFilter extends LogRequest {
   ...
   ...
 private int limit = 10;
   ...
   ...
   ```
   Admin.getLogEntries() takes one argument, which is object of either of above 
classes, hence we are already passing `limit` with this object.
   
   Here is how shell invokes call to Admin.getLogEntries:
   ```
   def get_balancer_decisions(args)
 balancer_decisions_req = 
org.apache.hadoop.hbase.client.BalancerDecisionRequest.new
 if args.key? 'LIMIT'   
   limit = args['LIMIT']
   balancer_decisions_req.setLimit(limit)   # if user provided limit in 
shell argument, use it, else default will be used.
 end
 balancer_decisions_responses = 
@admin.getLogEntries(balancer_decisions_req)
   ...
   ...
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] virajjasani commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox 


virajjasani commented on pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809


   We have two separate RPC APIs generic for Master and RS Rpcs:
   
   **RSRpcServices:**
   ```
 public AdminLogEntry getLogEntries(RpcController controller,
 AdminLogRequest request) throws ServiceException
   ```
   
   **MasterRpcServices:**
   ```
 public MasterProtos.MasterLogEntry getLogEntries(RpcController controller,
 MasterProtos.MasterLogRequest request) throws ServiceException
   ```
   
   And, we will be using ByteString from request/response objects to RPC APIs.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] virajjasani commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-21 Thread GitBox 


virajjasani commented on pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#issuecomment-678602243


   Ok, let me take care of this today.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] virajjasani commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-18 Thread GitBox 


virajjasani commented on pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#issuecomment-675607377


   @apurtell 
   Update so far:
   Addressed all concerns including generic Admin API for future use-cases.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] virajjasani commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-18 Thread GitBox 


virajjasani commented on pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#issuecomment-675434004


   I believe we should have generic Admin API for similar use-cases. For 
existing slowLog use-case, I can make it default implementation pointing to 
generic API and provide deprecation notice (with removal in 4.0.0 release).
   
   1. Addressed concerns other than providing generic Admin API for ring buffer 
use-cases.
   2. Let me take that up now and add as separate commit so that it becomes 
easier to review commit by commit.
   3. I can take up thrift changes as a follow up? (to avoid too many changes 
going in same commit)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org