[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-975344954 Also, now I see that @shahrs87 has also updated the description of the Jira HBASE-26468 and explained what exactly goes wrong and why server stays frozen if one of the non-daemon threads is not terminated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-975342397 > The problem here is that, why a crashed region server could return zero here? Why it does not return a non zero value? @Apache9 Regionserver doesn't crash, it exits normally. It prints log: `Stopping infoServer`, however the stop is not clean because one of the non-daemon thread is still running, because of which regionserver process stays in the hanging state and on the other hand, regionserver doesn't process any request because it has already stopped. Here, if we had System.exit(0), which does represent normal exit, then non-daemon thread would also not have stopped from exiting regionserver JVM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974660177 Backport PRs: #3865 #3866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974660177 Backport PRs: #3865 #3866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974327935 Yeah that sounds right, server would have already been unresponsive. Also, nothing happens after call to `ServerCommandLine#doMain` in master and regionserver main methods so we seem good here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974312848 This looks good actually, just wondering what could be the most destructive action that non-daemons could do. Maybe nothing? because regionserver/master is already (or in the progress of) shutdown? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
