[GitHub] [hbase] wchevreuil commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…
wchevreuil commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-657418801 We had decided to go with approach from HBASE-24664. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…
wchevreuil commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-651722529 > @wchevreuil > Thought it again, if this new splitPolicy is useable in branch-2.2 and branch-2.3, but disappear in branch-2.4 without deprecated cycle, is it break the compatibility guarantee? Yeah, we can't simply remove it between minor releases. > IMO, maybe we can do as below: > 1: In all actived branchs, add this new splitPolicy. Agreed! > 2: In minor branch set it as default policy and mark SteppingSpliyPolicy and IncreasingToUpperBoundRegionSplitPolicy as deprecated, at the same time fix the ConstantSizeRegionSplitPolicy. Just to confirm my understanding of your proposal: adding the new policy as default, deprecation of the overridden ones and fix of ConstantSizeRegionSplitPolicy should go on master and branch-2 branches, whilst branch-2.2 and branch-2.3 would only have the new policy added? If so, I'm +1 for that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…
wchevreuil commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-650299753 @bsglz , sorry for the delay. So majority of people on the DISCUSS thread opined towards #3. I think @busbey suggestion to fix IncreasingToUpperBoundRegionSplitPolicy for minor updates only is reasonable, so maybe we can merge this current one to branch-2.2 and branch-2.3, then for master and branch-2 we fix IncreasingToUpperBoundRegionSplitPolicy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…
wchevreuil commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-648309919 > IMO if we change split policy to consider region's total size rather than HStore size, we should also correct the config name. We can follow deprecation cycle for the config. But with current hregion.max.filesize its more confusing. > Now this config make sense because after a major compaction all the files under a Store will become single large file. So based on this max possible size we decide the split (So we sum all file's size under a store). I don't think changing the config name is strictly required. Official docs are clear about the expected behaviour for hbase.hregion.max.filesize, and this policy current violates that: `hbase.hregion.max.filesize Description Maximum HFile size. If the sum of the sizes of a region’s HFiles has grown to exceed this value, the region is split in two.` This policy also breaks MAX_FILESIZE table descriptor expected behaviour, as per ableDescriptorBuilder javadoc: `Returns the maximum size upto which a region can grow to after which a region split is triggered. The region size is represented by the size of the biggest store file in that region. ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…
wchevreuil commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-648078417 @bsglz , sorry for the delay. Let's give one more day for the DISCUSS thread. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] wchevreuil commented on pull request #1883: HBASE-24530 Introduce a split policy similar with SteppingSplitPolicy…
wchevreuil commented on pull request #1883: URL: https://github.com/apache/hbase/pull/1883#issuecomment-646565902 I have raised a discussion here: https://lists.apache.org/thread.html/r08a8103e2532eb667a0fcb4efa8a4117b3f82e6251bc4bd0bc157c26%40%3Cdev.hbase.apache.org%3E Let's wait for folks comments before we decide next steps for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
