[GitHub] [hbase-operator-tools] NihalJain commented on pull request #136: HBASE-27978 Add spotless in hbase-operator-tools pre-commit check

2023-08-31 Thread via GitHub


NihalJain commented on PR #136:
URL: 
https://github.com/apache/hbase-operator-tools/pull/136#issuecomment-1701030196

   - As seen in the above build spotless is added to pre-commit. 
   - Also, spotless fails for master as we have existing spotless issues in 
current master code. 
   - With this patch and spotless fix in 
`hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java`, spotless for patch is 
success. 
   
   Please let me know if need to raise another PR to fix spotless 1st, and then 
re-base and re-trigger this PR. 
   
   CC: @Apache9 , @petersomogyi , @wchevreuil 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [hbase-operator-tools] NihalJain commented on pull request #136: HBASE-27978 Add spotless in hbase-operator-tools pre-commit check

2023-09-05 Thread via GitHub


NihalJain commented on PR #136:
URL: 
https://github.com/apache/hbase-operator-tools/pull/136#issuecomment-1706558506

   Gentle ping @Apache9 @petersomogyi @wchevreuil Please let me know, if this 
is good to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org