[jira] [Assigned] (HBASE-16311) Audit log for delete snapshot operation is missing in case of snapshot owner deleting the same

2016-08-23 Thread Yi Liang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liang reassigned HBASE-16311:


Assignee: Yi Liang

> Audit log for delete snapshot operation is missing in case of snapshot owner 
> deleting the same
> --
>
> Key: HBASE-16311
> URL: https://issues.apache.org/jira/browse/HBASE-16311
> Project: HBase
>  Issue Type: Sub-task
>  Components: snapshots
>Reporter: Abhishek Kumar
>Assignee: Yi Liang
>Priority: Minor
> Attachments: HBASE-16311-V1.patch
>
>
> 1. Audit log seems to be left as a TODO task in AccessController.java:
> {code}
>   @Override
>   public void preDeleteSnapshot(final 
> ObserverContext ctx,
>   final SnapshotDescription snapshot) throws IOException {
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, getActiveUser())) {
>   // Snapshot owner is allowed to delete the snapshot
>   // TODO: We are not logging this for audit
> } else {
>   requirePermission("deleteSnapshot", Action.ADMIN);
> }
>   }
> {code}
> 2. Also, snapshot name is not getting logged in the audit logs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (HBASE-16311) Audit log for delete snapshot operation is missing in case of snapshot owner deleting the same

2016-08-01 Thread Abhishek Kumar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HBASE-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kumar reassigned HBASE-16311:
--

Assignee: Abhishek Kumar

> Audit log for delete snapshot operation is missing in case of snapshot owner 
> deleting the same
> --
>
> Key: HBASE-16311
> URL: https://issues.apache.org/jira/browse/HBASE-16311
> Project: HBase
>  Issue Type: Improvement
>  Components: snapshots
>Reporter: Abhishek Kumar
>Assignee: Abhishek Kumar
>Priority: Minor
>
> 1. Audit log seems to be left as a TODO task in AccessController.java:
> ...
> @Override
>   public void preDeleteSnapshot(final 
> ObserverContext ctx,
>   final SnapshotDescription snapshot) throws IOException {
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, getActiveUser())) {
>   // Snapshot owner is allowed to delete the snapshot
>   // TODO: We are not logging this for audit
> } else {
>   requirePermission("deleteSnapshot", Action.ADMIN);
> }
>   }
> ...
> 2. Also, snapshot name is not getting logged in the audit logs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)