[jira] [Assigned] (HBASE-18431) Mitigate compatibility concerns between branch-1.3 and branch-1.4
[ https://issues.apache.org/jira/browse/HBASE-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan reassigned HBASE-18431: Assignee: Andrew Purtell (was: Thiruvel Thirumoolan) > Mitigate compatibility concerns between branch-1.3 and branch-1.4 > - > > Key: HBASE-18431 > URL: https://issues.apache.org/jira/browse/HBASE-18431 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18431-branch-1.4.patch, > HBASE-18431-branch-1.patch, HBASE-18431-branch-2-WIP.patch > > > There are compatibility concerns with branch-1.4. > {noformat} > Library Name HBase > Version #11.3.1 > Version #21.4.0-SNAPSHOT > Subject Binary Compatibility > Compatibility - 89.9% > Added Methods - 305 > Removed Methods - 105 > Problems with Data Types > High - 23 > Medium - 9 > Low - 21 > {noformat} > {noformat} > Library Name HBase > Version #11.3.1 > Version #21.4.0-SNAPSHOT > Subject Source Compatibility > Compatibility- 86.5% > Added Methods - 305 > Removed Methods - 105 > Problems with Data Types > High - 88 > Medium - 0 > Low - 0 > Other Changes in Data Types- 25 > {noformat} > This report includes HBASE-15816 which hasn't been committed yet. Otherwise > it's current. > I'm not generally concerned with added methods. > The following methods have been added to Public/Evolving interface Table. > Pointing them out in case it merits review. > \\ > * Abstract method Table.getReadRpcTimeout ( ) has been added to this > interface. No effect. > * Abstract method Table.getWriteRpcTimeout ( ) has been added to this > interface. No effect. > * Abstract method Table.setReadRpcTimeout ( int ) has been added to this > interface. No effect. > * Abstract method Table.setWriteRpcTimeout ( int ) has been added to this > interface. > The Public/Evolving interface Admin has some signature changes equating to > removed methods. I don't think this is allowed in a minor release. > \\ > * Abstract method Admin.isSnapshotFinished ( HBaseProtos.SnapshotDescription > ) has been removed from Admin. > * Abstract method Admin.snapshot ( String, TableName, > HBaseProtos.SnapshotDescription.Type ) has been removed from Admin. > * Abstract method Admin.snapshot ( HBaseProtos.SnapshotDescription ) has been > removed from Admin. > * Abstract method Admin.takeSnapshotAsync ( HBaseProtos.SnapshotDescription > ) has been removed from Admin. > The LimitedPrivate(CONFIG) interface AsyncRpcClient has been removed. This > change is debatable but I think we can allow it. > \\ > * AsyncRpcClient has been removed > The Public/Evolving class FastLongHistogram has been removed. I don't believe > this change is allowed in a minor release. > \\ > * FastLongHistogram has been removed > Method signatures in LimitedPrivate(COPROC) interfaces MasterObserver and > RegionObserver have changed, equating to removed methods. The first set of > changes is due to move of SnapshotDescription from HBaseProtos to > SnapshotProtos: > \\ > * Abstract method MasterObserver.postCloneSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.postDeleteSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription ) has been removed from MasterObserver. > * Abstract method MasterObserver.postListSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription ) has been removed from MasterObserver. > * Abstract method MasterObserver.postRestoreSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.postSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.preCloneSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.preDeleteSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription ) has been removed from MasterObserver. > * Abstract method MasterObserver.preListSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription ) has been removed from MasterObserver. > * Abstract method MasterObserver.preRestoreSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.preSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. >
[jira] [Assigned] (HBASE-18431) Mitigate compatibility concerns between branch-1.3 and branch-1.4
[ https://issues.apache.org/jira/browse/HBASE-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thiruvel Thirumoolan reassigned HBASE-18431: Assignee: Thiruvel Thirumoolan (was: Andrew Purtell) > Mitigate compatibility concerns between branch-1.3 and branch-1.4 > - > > Key: HBASE-18431 > URL: https://issues.apache.org/jira/browse/HBASE-18431 > Project: HBase > Issue Type: Bug >Reporter: Andrew Purtell >Assignee: Thiruvel Thirumoolan >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18431-branch-1.4.patch, > HBASE-18431-branch-1.patch, HBASE-18431-branch-2-WIP.patch > > > There are compatibility concerns with branch-1.4. > {noformat} > Library Name HBase > Version #11.3.1 > Version #21.4.0-SNAPSHOT > Subject Binary Compatibility > Compatibility - 89.9% > Added Methods - 305 > Removed Methods - 105 > Problems with Data Types > High - 23 > Medium - 9 > Low - 21 > {noformat} > {noformat} > Library Name HBase > Version #11.3.1 > Version #21.4.0-SNAPSHOT > Subject Source Compatibility > Compatibility- 86.5% > Added Methods - 305 > Removed Methods - 105 > Problems with Data Types > High - 88 > Medium - 0 > Low - 0 > Other Changes in Data Types- 25 > {noformat} > This report includes HBASE-15816 which hasn't been committed yet. Otherwise > it's current. > I'm not generally concerned with added methods. > The following methods have been added to Public/Evolving interface Table. > Pointing them out in case it merits review. > \\ > * Abstract method Table.getReadRpcTimeout ( ) has been added to this > interface. No effect. > * Abstract method Table.getWriteRpcTimeout ( ) has been added to this > interface. No effect. > * Abstract method Table.setReadRpcTimeout ( int ) has been added to this > interface. No effect. > * Abstract method Table.setWriteRpcTimeout ( int ) has been added to this > interface. > The Public/Evolving interface Admin has some signature changes equating to > removed methods. I don't think this is allowed in a minor release. > \\ > * Abstract method Admin.isSnapshotFinished ( HBaseProtos.SnapshotDescription > ) has been removed from Admin. > * Abstract method Admin.snapshot ( String, TableName, > HBaseProtos.SnapshotDescription.Type ) has been removed from Admin. > * Abstract method Admin.snapshot ( HBaseProtos.SnapshotDescription ) has been > removed from Admin. > * Abstract method Admin.takeSnapshotAsync ( HBaseProtos.SnapshotDescription > ) has been removed from Admin. > The LimitedPrivate(CONFIG) interface AsyncRpcClient has been removed. This > change is debatable but I think we can allow it. > \\ > * AsyncRpcClient has been removed > The Public/Evolving class FastLongHistogram has been removed. I don't believe > this change is allowed in a minor release. > \\ > * FastLongHistogram has been removed > Method signatures in LimitedPrivate(COPROC) interfaces MasterObserver and > RegionObserver have changed, equating to removed methods. The first set of > changes is due to move of SnapshotDescription from HBaseProtos to > SnapshotProtos: > \\ > * Abstract method MasterObserver.postCloneSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.postDeleteSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription ) has been removed from MasterObserver. > * Abstract method MasterObserver.postListSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription ) has been removed from MasterObserver. > * Abstract method MasterObserver.postRestoreSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.postSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.preCloneSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.preDeleteSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription ) has been removed from MasterObserver. > * Abstract method MasterObserver.preListSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription ) has been removed from MasterObserver. > * Abstract method MasterObserver.preRestoreSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver. > * Abstract method MasterObserver.preSnapshot ( > ObserverContext, > HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from > MasterObserver.