[ https://issues.apache.org/jira/browse/HBASE-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223652#comment-14223652 ]
Andrew Purtell edited comment on HBASE-12550 at 11/24/14 10:32 PM: ------------------------------------------------------------------- This change breaks Apache Phoenix compilation: {code} diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/reg index 39a9fdc..3377e6b 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java @@ -4628,11 +4628,12 @@ public class HRegion implements HeapSize { // , Writable{ /** * Create a daughter region from given a temp directory with the region data. * @param hri Spec. for daughter region to open. + * @param expectedReferenceFileCount * @throws IOException */ - HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException { + HRegion createDaughterRegionFromSplits(final HRegionInfo hri, int expectedReferenceFileCount) throws IOException { // Move the files from the temporary .splits to the final /table/region directory - fs.commitDaughterRegion(hri); + fs.commitDaughterRegion(hri, expectedReferenceFileCount); {code} {noformat} [ERROR] /Users/apurtell/src/phoenix/phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexSplitTransaction.java:[364,28] method createDaughterRegionFromSplits in class org.apache.hadoop.hbase.regionserver.HRegion cannot be applied to given types; [ERROR] required: org.apache.hadoop.hbase.HRegionInfo,int [ERROR] found: org.apache.hadoop.hbase.HRegionInfo [ERROR] reason: actual and formal argument lists differ in length [ERROR] /Users/apurtell/src/phoenix/phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexSplitTransaction.java:[368,28] method createDaughterRegionFromSplits in class org.apache.hadoop.hbase.regionserver.HRegion cannot be applied to given types; [ERROR] required: org.apache.hadoop.hbase.HRegionInfo,int [ERROR] found: org.apache.hadoop.hbase.HRegionInfo [ERROR] reason: actual and formal argument lists differ in length {noformat} Can we get an addendum for 0.98 that fixes that? was (Author: apurtell): This change breaks Apache Phoenix compilation: {code} [ERROR] /Users/apurtell/src/phoenix/phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexSplitTransaction.java:[364,28] method createDaughterRegionFromSplits in class org.apache.hadoop.hbase.regionserver.HRegion cannot be applied to given types; [ERROR] required: org.apache.hadoop.hbase.HRegionInfo,int [ERROR] found: org.apache.hadoop.hbase.HRegionInfo [ERROR] reason: actual and formal argument lists differ in length [ERROR] /Users/apurtell/src/phoenix/phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexSplitTransaction.java:[368,28] method createDaughterRegionFromSplits in class org.apache.hadoop.hbase.regionserver.HRegion cannot be applied to given types; [ERROR] required: org.apache.hadoop.hbase.HRegionInfo,int [ERROR] found: org.apache.hadoop.hbase.HRegionInfo [ERROR] reason: actual and formal argument lists differ in length {code} Can we get an addendum for 0.98 that fixes that? > Check all storefiles are referenced before splitting > ---------------------------------------------------- > > Key: HBASE-12550 > URL: https://issues.apache.org/jira/browse/HBASE-12550 > Project: HBase > Issue Type: Bug > Reporter: Elliott Clark > Assignee: Elliott Clark > Fix For: 2.0.0, 0.98.9, 0.99.2 > > Attachments: > 0001-HBASE-12550-ADDENDUM-Check-all-storefiles-are-refere.patch, > HBASE-12550-v1.patch, HBASE-12550-v2.patch, HBASE-12550-v3.patch, > HBASE-12550.patch > > > Make double extra sure all storefiles are referenced before -- This message was sent by Atlassian JIRA (v6.3.4#6332)