[jira] [Comment Edited] (HBASE-13900) duplicate methods between ProtobufMagic and ProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593985#comment-14593985 ] Andrew Purtell edited comment on HBASE-13900 at 6/19/15 9:26 PM: - Not sure what's up with the javadoc warning either, I don't see it. Committed to master. Thanks for the patch [~gliptak]! was (Author: apurtell): Not sure what's up with the javadoc warning either, I don't see it. Committed to mater. Thanks for the patch [~gliptak]! > duplicate methods between ProtobufMagic and ProtobufUtil > > > Key: HBASE-13900 > URL: https://issues.apache.org/jira/browse/HBASE-13900 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Assignee: Gabor Liptak >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-13900.1.patch > > > Several methods duplicated between: > hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufMagic.java > and > hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java > isPBMagicPrefix() > isPBMagicPrefix() > lengthOfPBMagic() > ProtobufUtil partically references ProtobufMagic, but it also has different > compare implementation ... > Maybe this was based on packaging/signature need? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (HBASE-13900) duplicate methods between ProtobufMagic and ProtobufUtil
[ https://issues.apache.org/jira/browse/HBASE-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596219#comment-14596219 ] Andrew Purtell edited comment on HBASE-13900 at 6/22/15 4:56 PM: - [~misty] did the necessary revert and recommit already. Thanks [~misty]! was (Author: apurtell): [~misty] did the necessary revert an recommit already. Thanks [~misty]! > duplicate methods between ProtobufMagic and ProtobufUtil > > > Key: HBASE-13900 > URL: https://issues.apache.org/jira/browse/HBASE-13900 > Project: HBase > Issue Type: Improvement >Reporter: Gabor Liptak >Assignee: Gabor Liptak >Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-13900.1.patch > > > Several methods duplicated between: > hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufMagic.java > and > hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java > isPBMagicPrefix() > isPBMagicPrefix() > lengthOfPBMagic() > ProtobufUtil partically references ProtobufMagic, but it also has different > compare implementation ... > Maybe this was based on packaging/signature need? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
