[jira] [Comment Edited] (HBASE-18338) [C++] Implement RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078753#comment-16078753 ] Xiaobing Zhou edited comment on HBASE-18338 at 7/9/17 4:58 PM: --- Posted v0. # simplified the implementation a lot. # added RpcTestServerHandler and RpcTestServerPipelineFactory # added test.proto and test_rpc_service.proto from Java side in order to implement server stubs like echo/ping Will add implementation of server stubs by hooking protobuf engine into RpcTestServerHandler in next patch. was (Author: xiaobingo): Posted v0. # simplified the implementation a lot. # added RpcTestServerHandler and RpcTestServerPipelineFactory # added test.proto and test_rpc_service.proto from Java side in order to implement server stubs like echo/ping Will add implementation of server stubs to hook protobuf engine into RpcTestServerHandler in next patch. > [C++] Implement RpcTestServer > - > > Key: HBASE-18338 > URL: https://issues.apache.org/jira/browse/HBASE-18338 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18338.000.patch > > > This is a spin-off from HBASE-18078. We need RpcTestServer to simulate > various communication scenarios, e.g. timeout, connection aborted, long > running services and so on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18338) [C++] Implement RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081271#comment-16081271 ] Xiaobing Zhou edited comment on HBASE-18338 at 7/10/17 10:16 PM: - Posted v1. # learned from wangle RPC example, built a HBase test client and test server and the corresponding client/server handlers. # bridged native hbase::request and hbase::response into Bonk and Xtruct to do easy test Need some work to make it runnable in context of native hbase::request and hbase::response. was (Author: xiaobingo): Posted v1. # learned from wangle RPC example, built an HBase test client and test server and the corresponding client/server handlers. # bridged native hbase::request and hbase::response into Bonk and Xtruct to do easy test Need some work to make it runnable in context of native hbase::request and hbase::response. > [C++] Implement RpcTestServer > - > > Key: HBASE-18338 > URL: https://issues.apache.org/jira/browse/HBASE-18338 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18338.000.patch, HBASE-18338.001.patch > > > This is a spin-off from HBASE-18078. We need RpcTestServer to simulate > various communication scenarios, e.g. timeout, connection aborted, long > running services and so on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18338) [C++] Implement RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084771#comment-16084771 ] Xiaobing Zhou edited comment on HBASE-18338 at 7/12/17 9:50 PM: Posted v2: # being able to do ping/pong # removed Bonk and Xtruct # fixed all compile issues # changed serde/rpc.h&rpc.cc to serde/rpc-serde.h&rpc-serde.cc for less confusion. Will port protobuf types into RPC test client/server by protobuf-compiling test.proto and test_rpc_service.proto. was (Author: xiaobingo): Posted v2: # being able to do ping/pong # removed Bonk and Xtruct # fixed all compile issues Will port protobuf types into RPC test client/server by protobuf-compiling test.proto and test_rpc_service.proto. > [C++] Implement RpcTestServer > - > > Key: HBASE-18338 > URL: https://issues.apache.org/jira/browse/HBASE-18338 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18338.000.patch, HBASE-18338.001.patch, > HBASE-18338.002.patch > > > This is a spin-off from HBASE-18078. We need RpcTestServer to simulate > various communication scenarios, e.g. timeout, connection aborted, long > running services and so on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18338) [C++] Implement RpcTestServer
[ https://issues.apache.org/jira/browse/HBASE-18338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092369#comment-16092369 ] Xiaobing Zhou edited comment on HBASE-18338 at 7/19/17 12:09 AM: - posted patch v5. # reuses RpcClient in test # introduces Configuration::HBASE_CLIENT_RPC_TEST_MODE to bypass some code for RPC test only, otherwise tests will fail given RpcTestServer implementation. # binds to port 0 to be ephemeral # throws exception in test # removes rpc-test-client.h and rpc-test-client-handler.h Let's refill the TODO in follow up patch, thanks [~enis] for reviews. was (Author: xiaobingo): posted patch v5. # reuses RpcClient in test # binds to port 0 to be ephemeral # throws exception in test # removes rpc-test-client.h and rpc-test-client-handler.h Let's refill the TODO in follow up patch, thanks [~enis] for reviews. > [C++] Implement RpcTestServer > - > > Key: HBASE-18338 > URL: https://issues.apache.org/jira/browse/HBASE-18338 > Project: HBase > Issue Type: Sub-task >Reporter: Xiaobing Zhou >Assignee: Xiaobing Zhou > Attachments: HBASE-18338.000.patch, HBASE-18338.001.patch, > HBASE-18338.002.patch, HBASE-18338.003.patch, HBASE-18338.004.patch, > HBASE-18338.005.patch > > > This is a spin-off from HBASE-18078. We need RpcTestServer to simulate > various communication scenarios, e.g. timeout, connection aborted, long > running services and so on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
