[jira] [Comment Edited] (HBASE-20172) During coprocessor load, switch classloader only if it's a custom CP.

[Ankit Singhal (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-20172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489838#comment-16489838
 ] 

Ankit Singhal edited comment on HBASE-20172 at 5/24/18 9:34 PM:


ping [~stack],

[~apurtell] , shouldn't we need this fix to avoid failures if we are still 
supporting JDK 1.7 for branch-1?

One user also seeing something similar:-
http://mail-archives.apache.org/mod_mbox/phoenix-user/201805.mbox/%3CCAF1+Vs_TFcZ23zg8nfrZ8TDfpk_4oYYJpu5bFNXybBEFYJ=a...@mail.gmail.com%3E


was (Author: an...@apache.org):
ping [~stack],

[~apurtell] , shouldn't we need this fix to avoid failures if we are still 
supporting JDK 1.7 for branch-1?

> During coprocessor load, switch classloader only if it's a custom CP.
> -
>
> Key: HBASE-20172
> URL: https://issues.apache.org/jira/browse/HBASE-20172
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-20172.patch
>
>
> Current Impact:- 
> Metric registries will not be able to load its implementation through service 
> loader and etc.
> We are not observing this with Java8 because ServiceLoader uses system class 
> loader if provided class loader is null but it gets exposed with Java7 
> easily(TEPHRA-285)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (HBASE-20172) During coprocessor load, switch classloader only if it's a custom CP.

[Ankit Singhal (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-20172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490074#comment-16490074
 ] 

Ankit Singhal edited comment on HBASE-20172 at 5/25/18 1:14 AM:


[~apurtell], I'm not able to reproduce the test failure locally on branch-1.
{code}
[ERROR] Tests run: 84, Failures: 1, Errors: 0, Skipped: 4, Time elapsed: 
227.777 s <<< FAILURE! - in 
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
[ERROR] 
testCheckAndDeleteWithCompareOp(org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor)
  Time elapsed: 1.337 s  <<< FAILURE!
java.lang.AssertionError: expected: but was:
{code}


was (Author: an...@apache.org):
[~apurtell], I'm not able to reproduce the test failure locally.
{code}
[ERROR] Tests run: 84, Failures: 1, Errors: 0, Skipped: 4, Time elapsed: 
227.777 s <<< FAILURE! - in 
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
[ERROR] 
testCheckAndDeleteWithCompareOp(org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor)
  Time elapsed: 1.337 s  <<< FAILURE!
java.lang.AssertionError: expected: but was:
{code}

> During coprocessor load, switch classloader only if it's a custom CP.
> -
>
> Key: HBASE-20172
> URL: https://issues.apache.org/jira/browse/HBASE-20172
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.4.0
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-20172-branch-1.patch, HBASE-20172.patch
>
>
> Current Impact:- 
> Metric registries will not be able to load its implementation through service 
> loader and etc.
> We are not observing this with Java8 because ServiceLoader uses system class 
> loader if provided class loader is null but it gets exposed with Java7 
> easily(TEPHRA-285)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)