[jira] [Comment Edited] (HBASE-20259) Doc configs for in-memory-compaction and add detail to in-memory-compaction logging
[
https://issues.apache.org/jira/browse/HBASE-20259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421993#comment-16421993
]
Edward Bortnikov edited comment on HBASE-20259 at 4/2/18 7:29 AM:
--
[~stack] let's take the decision in a broader context of the overall
performance evaluation methodology. Tons of effort have been invested in
exploring CompactingMemstore, including the off-heap path. The demonstrated
performance benefits were decisive. Let's avoid haste just now.
We're now on testing the system in the settings that have not been expected
before (CMS+MSLAB on-heap combination), still need some time to figure out
what's going on. Stay tuned sir ..
was (Author: ebortnik):
[~stack] let's take the decision in a broader context of the overall
performance evaluation methodology. Tons of effort have been invested in
exploring CompactingMemstore, and the demonstrated performance benefits were
decisive. Let's avoid haste just now.
We're now on testing the system in the settings that have not been expected
before (CMS+MSLAB on-heap combination), still need some time to figure out
what's going on. Stay tuned sir ..
> Doc configs for in-memory-compaction and add detail to in-memory-compaction
> logging
> ---
>
> Key: HBASE-20259
> URL: https://issues.apache.org/jira/browse/HBASE-20259
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20259.master.001.patch,
> HBASE-20259.master.002.patch, HBASE-20259.master.003.patch
>
>
> I set {{hbase.systemtables.compacting.memstore.type}} to NONE but it seems
> like in-memory is still on. My table looks like this:
> {code}
> Table ycsb is ENABLED
> ycsb
> COLUMN FAMILIES DESCRIPTION
> {NAME => 'family', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false',
> NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE',
> CACHE_DATA_ON_WRITE => 'false', DATA_BLOCK_ENCODING => 'NONE', TTL =>
> 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER =
> > 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMORY => 'false',
> > CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false',
> > COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536'}
> {code}
> Looks like table doesn't have it on either (IN_MEMORY_COMPACTION doesn't show
> in the above).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-20259) Doc configs for in-memory-compaction and add detail to in-memory-compaction logging
[
https://issues.apache.org/jira/browse/HBASE-20259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421963#comment-16421963
]
stack edited comment on HBASE-20259 at 4/2/18 6:39 AM:
---
bq. Please reconsider delaying the decision about CompactingMemStore's default.
Thank you!
Lets move changing the default to a new issue. Enjoy your time off in meantime.
On tests, I'm running the most basic of compares; if in-memory-compaction
doesn't help in this case, if it is actually detrimental, then we should turn
it off as default and talk it up in refguide when you'd use it and how you can
see the benefit it brings
But for another issue. Ok with the rest of this patch going in [~anastas] ?
Putting up new patch that leaves in memory compaction enabled. Thanks.
was (Author: stack):
bq. Please reconsider delaying the decision about CompactingMemStore's default.
Thank you!
Lets move changing the default to a new issue. Enjoy your time off in meantime.
On tests, I'm running the most basic of compares; if in-memory-compaction
doesn't help in this case, we should turn it off as default and talk up in
refguide when you'd use it and how you can see the benefit it brings But
for another issue. Ok with the rest of this patch going in [~anastas] ? Thanks.
> Doc configs for in-memory-compaction and add detail to in-memory-compaction
> logging
> ---
>
> Key: HBASE-20259
> URL: https://issues.apache.org/jira/browse/HBASE-20259
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20259.master.001.patch,
> HBASE-20259.master.002.patch
>
>
> I set {{hbase.systemtables.compacting.memstore.type}} to NONE but it seems
> like in-memory is still on. My table looks like this:
> {code}
> Table ycsb is ENABLED
> ycsb
> COLUMN FAMILIES DESCRIPTION
> {NAME => 'family', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false',
> NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE',
> CACHE_DATA_ON_WRITE => 'false', DATA_BLOCK_ENCODING => 'NONE', TTL =>
> 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER =
> > 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMORY => 'false',
> > CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false',
> > COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536'}
> {code}
> Looks like table doesn't have it on either (IN_MEMORY_COMPACTION doesn't show
> in the above).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
