[jira] [Comment Edited] (HBASE-21478) Make table sorted when displaying rsgroup info in shell and master web UI
[
https://issues.apache.org/jira/browse/HBASE-21478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764178#comment-16764178
]
Xiang Li edited comment on HBASE-21478 at 2/9/19 4:21 PM:
--
Without the patch:
{code}
hbase(main):004:0> list_rsgroups
NAME SERVER /
TABLE
default server
ip-10-23-10-9.ec2.internal:16020
table
hbase:meta
table
hbase:rsgroup
table t1
table
ns1:t2
1 row(s)
Took 0.1633 seconds
hbase(main):006:0> get_rsgroup 'default'
SERVERS
ip-10-23-10-9.ec2.internal:16020
1 row(s)
TABLES
hbase:meta
hbase:rsgroup
t1
ns1:t2
4 row(s)
{code}
was (Author: water):
Without the patch:
{code}
hbase(main):004:0> list_rsgroups
NAME SERVER /
TABLE
default server
ip-10-23-10-9.ec2.internal:16020
table
hbase:meta
[jira] [Comment Edited] (HBASE-21478) Make table sorted when displaying rsgroup info in shell and master web UI
[
https://issues.apache.org/jira/browse/HBASE-21478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764178#comment-16764178
]
Xiang Li edited comment on HBASE-21478 at 2/9/19 4:22 PM:
--
Without the patch:
{code:java}
hbase(main):002:0> list_rsgroups
NAME SERVER /
TABLE
default server
ip-10-23-10-9.ec2.internal:16020
table
ns1:t2
table
hbase:meta
table t1
table
hbase:rsgroup
1 row(s)
Took 0.1516 seconds
hbase(main):003:0> get_rsgroup 'default'
SERVERS
ip-10-23-10-9.ec2.internal:16020
1 row(s)
TABLES
ns1:t2
hbase:meta
t1
hbase:rsgroup
4 row(s)
Took 0.0160 seconds
{code}
With the patch:
{code:java}
hbase(main):004:0> list_rsgroups
NAME SERVER /
TABLE
default server
ip-10-23-10-9.ec2.internal:16020
table
hbase:
[jira] [Comment Edited] (HBASE-21478) Make table sorted when displaying rsgroup info in shell and master web UI
[
https://issues.apache.org/jira/browse/HBASE-21478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686494#comment-16686494
]
Xiang Li edited comment on HBASE-21478 at 11/14/18 1:39 PM:
I do not plan to change the logic of TableName#compareTo(), because
RSGroupInfo#getTables() has a lot of usage. As an alternative, I only plan to
update the output when displayed: May I provide a new function called
RSGroupInfo#getTablesSortedByNamespaceAndName() and use the new function in
hbase shell and master web UI when the tables are displayed? Make any sense to
you ? [~yuzhih...@gmail.com]
was (Author: water):
I do not plan to change the logic of TableName#compareTo(), because
RSGroupInfo#getTables() has a lot of usage. As an alternative, I only plan to
update the output when displayed: May I provide a new function called
RSGroupInfo#getTablesSortedByNamespaceAndName() and use the new function in
hbase shell and master web UI when the tables are displayed?
> Make table sorted when displaying rsgroup info in shell and master web UI
> -
>
> Key: HBASE-21478
> URL: https://issues.apache.org/jira/browse/HBASE-21478
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Reporter: Xiang Li
>Assignee: Xiang Li
>Priority: Major
>
> Regarding the output of the command of "get_rsgoup" in hbase shell, or the
> section of "Server Group" of HMaster's web UI, the tables are not sorted, so
> not quite easy to read, like:
> {code}
> hbase(main):003:0> get_rsgroup 'default'
> GROUP INFORMATION
> ...
> Tables:
> table3
> ns2:table22
> table1
> ns1:table11
> ...
> {code}
> They could be sorted in the order of namespace then table name:
> {code}
> table1
> table3
> ns1:table11
> ns2:table22
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21478) Make table sorted when displaying rsgroup info in shell and master web UI
[
https://issues.apache.org/jira/browse/HBASE-21478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686510#comment-16686510
]
Xiang Li edited comment on HBASE-21478 at 11/14/18 1:47 PM:
I believe HBASE-17624 makes servers ordered by hostname then port as it
provides compareTo() in Address class, as follow. So server does not have the
same pain as table. Please correct me if I am wrong here.
{code}
@Override
public int compareTo(Address that) {
int compare = this.getHostname().compareTo(that.getHostname());
if (compare != 0) return compare;
return this.getPort() - that.getPort();
}
{code}
was (Author: water):
I believe HBASE-17624 makes servers ordered by hostname then port as it
provides compareTo() in Address class, as follow. Please correct me if I am
wrong here.
{code}
@Override
public int compareTo(Address that) {
int compare = this.getHostname().compareTo(that.getHostname());
if (compare != 0) return compare;
return this.getPort() - that.getPort();
}
{code}
> Make table sorted when displaying rsgroup info in shell and master web UI
> -
>
> Key: HBASE-21478
> URL: https://issues.apache.org/jira/browse/HBASE-21478
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Reporter: Xiang Li
>Assignee: Xiang Li
>Priority: Major
>
> Regarding the output of the command of "get_rsgoup" in hbase shell, or the
> section of "Server Group" of HMaster's web UI, the tables are not sorted, so
> not quite easy to read, like:
> {code}
> hbase(main):003:0> get_rsgroup 'default'
> GROUP INFORMATION
> ...
> Tables:
> table3
> ns2:table22
> table1
> ns1:table11
> ...
> {code}
> They could be sorted in the order of namespace then table name:
> {code}
> table1
> table3
> ns1:table11
> ns2:table22
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21478) Make table sorted when displaying rsgroup info in shell and master web UI
[
https://issues.apache.org/jira/browse/HBASE-21478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686510#comment-16686510
]
Xiang Li edited comment on HBASE-21478 at 11/14/18 1:47 PM:
I believe HBASE-17624 makes servers ordered by hostname then port as it
provides compareTo() in Address class, as follow. So server does not have the
same pain as table, when displayed. Please correct me if I am wrong here.
{code}
@Override
public int compareTo(Address that) {
int compare = this.getHostname().compareTo(that.getHostname());
if (compare != 0) return compare;
return this.getPort() - that.getPort();
}
{code}
was (Author: water):
I believe HBASE-17624 makes servers ordered by hostname then port as it
provides compareTo() in Address class, as follow. So server does not have the
same pain as table. Please correct me if I am wrong here.
{code}
@Override
public int compareTo(Address that) {
int compare = this.getHostname().compareTo(that.getHostname());
if (compare != 0) return compare;
return this.getPort() - that.getPort();
}
{code}
> Make table sorted when displaying rsgroup info in shell and master web UI
> -
>
> Key: HBASE-21478
> URL: https://issues.apache.org/jira/browse/HBASE-21478
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Reporter: Xiang Li
>Assignee: Xiang Li
>Priority: Major
>
> Regarding the output of the command of "get_rsgoup" in hbase shell, or the
> section of "Server Group" of HMaster's web UI, the tables are not sorted, so
> not quite easy to read, like:
> {code}
> hbase(main):003:0> get_rsgroup 'default'
> GROUP INFORMATION
> ...
> Tables:
> table3
> ns2:table22
> table1
> ns1:table11
> ...
> {code}
> They could be sorted in the order of namespace then table name:
> {code}
> table1
> table3
> ns1:table11
> ns2:table22
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21478) Make table sorted when displaying rsgroup info in shell and master web UI
[
https://issues.apache.org/jira/browse/HBASE-21478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686510#comment-16686510
]
Xiang Li edited comment on HBASE-21478 at 11/14/18 1:46 PM:
I believe HBASE-17624 makes servers ordered by hostname then port as it
provides compareTo() in Address class, as follow. Please correct me if I am
wrong here.
{code}
@Override
public int compareTo(Address that) {
int compare = this.getHostname().compareTo(that.getHostname());
if (compare != 0) return compare;
return this.getPort() - that.getPort();
}
{code}
was (Author: water):
I believe HBASE-17624 makes servers ordered by hostname then port as it
provides compareTo() in Address class. Please correct me if I am wrong here.
> Make table sorted when displaying rsgroup info in shell and master web UI
> -
>
> Key: HBASE-21478
> URL: https://issues.apache.org/jira/browse/HBASE-21478
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Reporter: Xiang Li
>Assignee: Xiang Li
>Priority: Major
>
> Regarding the output of the command of "get_rsgoup" in hbase shell, or the
> section of "Server Group" of HMaster's web UI, the tables are not sorted, so
> not quite easy to read, like:
> {code}
> hbase(main):003:0> get_rsgroup 'default'
> GROUP INFORMATION
> ...
> Tables:
> table3
> ns2:table22
> table1
> ns1:table11
> ...
> {code}
> They could be sorted in the order of namespace then table name:
> {code}
> table1
> table3
> ns1:table11
> ns2:table22
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HBASE-21478) Make table sorted when displaying rsgroup info in shell and master web UI
[
https://issues.apache.org/jira/browse/HBASE-21478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690951#comment-16690951
]
Xiang Li edited comment on HBASE-21478 at 11/18/18 4:39 PM:
[~yuzhih...@gmail.com] RSGroupInfo#getTables() references a SortedSet(TreeSet).
And I plan to create another SortedSet which is sorted in terms of
TableName#namespaceAsString then TableName#nameAsString.
It seems it will create a lot of SortedSet if I new a SortedSet in
getTablesSortedByNamespaceAndName(), what about adding another private member
as a copy of tables into RSGroupInfo, and refreshing it from the existing
"tables" whenever getTablesSortedByNamespaceAndName() is called.
was (Author: water):
[~yuzhih...@gmail.com] RSGroupInfo#getTables() references a SortedSet(TreeSet).
And I plan to create another SortedSet which is sorted in terms of
TableName#namespaceAsString then TableName#nameAsString.
It seems it will create a lot of SortedSet if I new a SortedSet in
getTablesSortedByNamespaceAndName(), what about adding another private member
as a copy of tables into RSGroupInfo, and rebuilding it from the existing
"tables" whenever getTablesSortedByNamespaceAndName() is called.
> Make table sorted when displaying rsgroup info in shell and master web UI
> -
>
> Key: HBASE-21478
> URL: https://issues.apache.org/jira/browse/HBASE-21478
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
>Reporter: Xiang Li
>Assignee: Xiang Li
>Priority: Minor
>
> Regarding the output of the command of "get_rsgoup" in hbase shell, or the
> section of "Server Group" of HMaster's web UI, the tables are not sorted, so
> not quite easy to read, like:
> {code}
> hbase(main):003:0> get_rsgroup 'default'
> GROUP INFORMATION
> ...
> Tables:
> table3
> ns2:table22
> table1
> ns1:table11
> ...
> {code}
> They could be sorted in the order of namespace then table name:
> {code}
> table1
> table3
> ns1:table11
> ns2:table22
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
