[jira] [Comment Edited] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243312#comment-17243312
]
Viraj Jasani edited comment on HBASE-25246 at 12/3/20, 4:20 PM:
RSRpcServices has this logic:
{code:java}
private void addResults(ScanResponse.Builder builder, List results,
HBaseRpcController controller, boolean isDefaultRegion, boolean
clientCellBlockSupported) {
builder.setStale(!isDefaultRegion);
if (results.isEmpty()) {
return;
}
if (clientCellBlockSupported) {
for (Result res : results) {
builder.addCellsPerResult(res.size());
builder.addPartialFlagPerResult(res.mayHaveMoreCellsInRow());
}
controller.setCellScanner(CellUtil.createCellScanner(results));
} else {
for (Result res : results) {
ClientProtos.Result pbr = ProtobufUtil.toResult(res);
builder.addResults(pbr);
}
}
}
{code}
Hence, if client doesn't have cellBlock supported, we go to
ProtobufUtil.toResult(final Result result), which internally calls
ProtobufUtil.toCell(final Cell kv) and hence, kvbuilder.setTags() (as per PR
#2706) is executed.
ServerCall:
{code:java}
@Override
public boolean isClientCellBlockSupported() {
return this.connection != null && this.connection.codec != null;
}
{code}
was (Author: vjasani):
RSRpcServices has this logic:
{code:java}
if (clientCellBlockSupported) {
for (Result res : results) {
builder.addCellsPerResult(res.size());
builder.addPartialFlagPerResult(res.mayHaveMoreCellsInRow());
}
controller.setCellScanner(CellUtil.createCellScanner(results));
} else {
for (Result res : results) {
ClientProtos.Result pbr = ProtobufUtil.toResult(res);
builder.addResults(pbr);
}
}
{code}
Hence, if client doesn't have cellBlock supported, we go to
ProtobufUtil.toResult(final Result result), which internally calls
ProtobufUtil.toCell(final Cell kv) and hence, kvbuilder.setTags() (as per PR
#2706) is executed.
ServerCall:
{code:java}
@Override
public boolean isClientCellBlockSupported() {
return this.connection != null && this.connection.codec != null;
}
{code}
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backup&restore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-25246) Backup/Restore hbase cell tags.
[
https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243312#comment-17243312
]
Viraj Jasani edited comment on HBASE-25246 at 12/3/20, 4:19 PM:
RSRpcServices has this logic:
{code:java}
if (clientCellBlockSupported) {
for (Result res : results) {
builder.addCellsPerResult(res.size());
builder.addPartialFlagPerResult(res.mayHaveMoreCellsInRow());
}
controller.setCellScanner(CellUtil.createCellScanner(results));
} else {
for (Result res : results) {
ClientProtos.Result pbr = ProtobufUtil.toResult(res);
builder.addResults(pbr);
}
}
{code}
Hence, if client doesn't have cellBlock supported, we go to
ProtobufUtil.toResult(final Result result), which internally calls
ProtobufUtil.toCell(final Cell kv) and hence, kvbuilder.setTags() (as per PR
#2706) is executed.
ServerCall:
{code:java}
@Override
public boolean isClientCellBlockSupported() {
return this.connection != null && this.connection.codec != null;
}
{code}
was (Author: vjasani):
RSRpcServices has this logic:
{code:java}
if (clientCellBlockSupported) {
for (Result res : results) {
builder.addCellsPerResult(res.size());
builder.addPartialFlagPerResult(res.mayHaveMoreCellsInRow());
}
controller.setCellScanner(CellUtil.createCellScanner(results));
} else {
for (Result res : results) {
ClientProtos.Result pbr = ProtobufUtil.toResult(res);
builder.addResults(pbr);
}
}
{code}
Hence, if client doesn't have cellBlock supported, we go to
ProtobufUtil.toResult(final Result result), which internally calls
ProtobufUtil.toCell(final Cell kv) and hence, kvbuilder.setTags() (as per PR
#2706) is executed.
> Backup/Restore hbase cell tags.
> ---
>
> Key: HBASE-25246
> URL: https://issues.apache.org/jira/browse/HBASE-25246
> Project: HBase
> Issue Type: Improvement
> Components: backup&restore
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After
> having a discussion with hbase community via dev mailing thread, it was
> decided that we will pass the tags via an attribute in Mutation object and
> persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213
> is to store metadata in Delete marker so that while running Restore tool we
> can selectively restore certain Delete markers and ignore others. For that to
> happen we need to persist these tags in Backup and retrieve them in Restore
> MR jobs (Import/Export tool).
> Currently we don't persist the tags in Backup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242469#comment-17242469 ] Viraj Jasani edited comment on HBASE-25246 at 12/2/20, 4:14 PM: [~shahrs87] The patch is committed to trunk and all active branch-2's. Can you also create branch-1 PR? FYI [~apurtell] If you are planning to roll 2.4 RC today, we can resolve this Jira with applicable versions and create branch-1 backport subtask? Thanks was (Author: vjasani): [~shahrs87] The patch is committed to trunk and all active branch-2's. Can you also create branch-1 PR? Thanks > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backup&restore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226365#comment-17226365 ] Andrew Kyle Purtell edited comment on HBASE-25246 at 11/4/20, 7:47 PM: --- Cell tags are persisted in store files. A snapshot based backup/restore foundation will capture tags because they preserve the store files containing them. To the extent that meets your needs, at least you have that. Agreed, to extract tags along with the rest of the cell data into some other format requires a tooling improvement. Makes sense. was (Author: apurtell): Cell tags are persisted in store files. A snapshot based backup/restore foundation will capture tags. To the extent that meets your needs, at least you have that. Agreed, to extract tags along with the rest of the cell data into some other format requires a tooling improvement. Makes sense. > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backup&restore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-25246) Backup/Restore hbase cell tags.
[ https://issues.apache.org/jira/browse/HBASE-25246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226311#comment-17226311 ] Rushabh Shah edited comment on HBASE-25246 at 11/4/20, 5:56 PM: Cc [~apurtell] [~gjacoby] was (Author: shahrs87): Cc [~andrew.purt...@gmail.com] [~gjacoby] > Backup/Restore hbase cell tags. > --- > > Key: HBASE-25246 > URL: https://issues.apache.org/jira/browse/HBASE-25246 > Project: HBase > Issue Type: Improvement > Components: backup&restore >Reporter: Rushabh Shah >Assignee: Rushabh Shah >Priority: Major > > In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After > having a discussion with hbase community via dev mailing thread, it was > decided that we will pass the tags via an attribute in Mutation object and > persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 > is to store metadata in Delete marker so that while running Restore tool we > can selectively restore certain Delete markers and ignore others. For that to > happen we need to persist these tags in Backup and retrieve them in Restore > MR jobs (Import/Export tool). > Currently we don't persist the tags in Backup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
