[jira] [Comment Edited] (HBASE-8329) Limit compaction speed

2015-02-04 Thread Andrew Purtell (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306542#comment-14306542
 ] 

Andrew Purtell edited comment on HBASE-8329 at 2/5/15 2:58 AM:
---

I don't see a compatibility problem with the 0.98 patch. The affected existing 
interfaces are

{panel:title=CompactionContext}
Annotated Private
Removes List compact ( )
Adds List compact ( CompactionContext, CompactionThroughputController)
{panel}

{panel:title=Compactor}
Annotated Private
Removes boolean performCompaction ( InternalScanner, CellSink, long )
Adds boolean performCompaction ( InternalScanner, CellSink, long, 
CompactionThroughputController )
{panel}

{panel:title=HRegion}
Annotated Private
Removes boolean compact ( CompactionContext, Store )
Adds boolean compact ( CompactionContext, Store, CompactionThroughputController)
Adds double getCompactionPressure ( )
{panel}

{panel:title=HRegionServer}
Annotated Private
Adds double getCompactionPressure ( )
{panel}

{panel:title=HStore}
Annotated Private
Removes List compact ( CompactionContext )
Adds List compact ( CompactionContext, 
CompactionThroughputController)
Adds double getCompactionPressure ( )
{panel}

{panel:title=Store}
Annotated Private
Removes List compact ( CompactionContext )
Adds List compact ( CompactionContext, 
CompactionThroughputController)
Adds double getCompactionPressure ( )
{panel}

{panel:title=RegionServerServices}
Annotated Private (probably should be annotated LimitedPrivate(COPROC)/Evolving)
Adds double getCompactionPressure ( )
{panel}

{panel:title=StoreFileManager}
Annotated Private
Adds double StoreFileManager.getCompactionPressure ( )
{panel}

They are all annotated private. If we really want to be sure, we can add back:
- Store#compact ( CompactionContext )
- CompactionContext#compact ( )



was (Author: apurtell):
I don't see a compatibility problem with the 0.98 patch. The affected existing 
interfaces are

{panel:title=CompactionContext}
Annotated Private
Removes List compact ( )
Adds List compact ( CompactionContext, CompactionThroughputController)
{panel}

{panel:title=Compactor}
Annotated Private
Removes boolean performCompaction ( InternalScanner, CellSink, long )
Adds boolean performCompaction ( InternalScanner, CellSink, long, 
CompactionThroughputController )
{panel}

{panel:title=HRegion}
Annotated Private
Removes boolean compact ( CompactionContext, Store )
Adds boolean compact ( CompactionContext, Store, CompactionThroughputController)
Adds double getCompactionPressure ( )
{panel}

{panel:title=HRegionServer}
Annotated Private
Adds double getCompactionPressure ( )
{panel}

{panel:title=HStore}
Annotated Private
Removes List compact ( CompactionContext )
Adds List compact ( CompactionContext, 
CompactionThroughputController)
Adds double getCompactionPressure ( )
{panel}

{panel:title=Store}
Annotated Private
Removes List compact ( CompactionContext )
Adds List compact ( CompactionContext, 
CompactionThroughputController)
Adds double getCompactionPressure ( )
{panel}

{panel:title=StoreFileManager}
Annotated Private
Adds double StoreFileManager.getCompactionPressure ( )
{panel}

They are all annotated private. If we really want to be sure, we can add back:
- Store#compact ( CompactionContext )
- CompactionContext#compact ( )


> Limit compaction speed
> --
>
> Key: HBASE-8329
> URL: https://issues.apache.org/jira/browse/HBASE-8329
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: binlijin
>Assignee: zhangduo
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-8329-0.98.patch, HBASE-8329-10.patch, 
> HBASE-8329-11.patch, HBASE-8329-12.patch, HBASE-8329-2-trunk.patch, 
> HBASE-8329-3-trunk.patch, HBASE-8329-4-trunk.patch, HBASE-8329-5-trunk.patch, 
> HBASE-8329-6-trunk.patch, HBASE-8329-7-trunk.patch, HBASE-8329-8-trunk.patch, 
> HBASE-8329-9-trunk.patch, HBASE-8329-branch-1.patch, HBASE-8329-trunk.patch, 
> HBASE-8329_13.patch, HBASE-8329_14.patch, HBASE-8329_15.patch, 
> HBASE-8329_16.patch, HBASE-8329_17.patch
>
>
> There is no speed or resource limit for compaction，I think we should add this 
> feature especially when request burst.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (HBASE-8329) Limit compaction speed

2015-01-10 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272514#comment-14272514
 ] 

Ted Yu edited comment on HBASE-8329 at 1/10/15 2:21 PM:


{code}
+@InterfaceAudience.Private
+public interface ThroughputController {
{code}
LimitedPrivate annotation should be used - same with the controllers which 
implement the interface.
Please add javadoc for each method.
{code}
+  void cancelupThroughputTuner();
{code}
Remove 'up' in the name of the above method.
{code}
+  public void cancelupThroughputTuner() {
+stop("Cancel Throughput Tuner");
{code}
Since cancel method calls stop(), is cancelThroughputTuner() needed ?


was (Author: yuzhih...@gmail.com):
{code}
+@InterfaceAudience.Private
+public interface ThroughputController {
{code}
LimitedPrivate annotation should be used - same with the controllers which 
implement the interface.
Please add javadoc for each method.
{code}
+  void cancelupThroughputTuner();
{code}
Remove 'up' in the name of the above method.

> Limit compaction speed
> --
>
> Key: HBASE-8329
> URL: https://issues.apache.org/jira/browse/HBASE-8329
> Project: HBase
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: binlijin
>Assignee: zhangduo
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-8329-10.patch, HBASE-8329-11.patch, 
> HBASE-8329-12.patch, HBASE-8329-2-trunk.patch, HBASE-8329-3-trunk.patch, 
> HBASE-8329-4-trunk.patch, HBASE-8329-5-trunk.patch, HBASE-8329-6-trunk.patch, 
> HBASE-8329-7-trunk.patch, HBASE-8329-8-trunk.patch, HBASE-8329-9-trunk.patch, 
> HBASE-8329-trunk.patch, HBASE-8329_13.patch
>
>
> There is no speed or resource limit for compaction，I think we should add this 
> feature especially when request burst.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)