[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167068#comment-14167068 ] stack commented on HBASE-10087: --- [~nkeywal] See comment above > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163290#comment-14163290 ] zhangduo commented on HBASE-10087: -- I think the lock here is not used to prevent concurrent snapshot of memstore, but to prevent create MemStoreScanner(holding the read lock) and snapshot running concurrently. If we do not hold write lock here, we can get an inconsistent view of kvsetAtCreation, snapshotAtCreation, allocator and snapshotAllocator when creating MemStoreScanner(kvsetAtCreation and snapshotAtCreation could be a same instance, snapshotAllocator is not the actual allocator of snapshotAtCreation and so on). This is OK for now because our implementation(very very tricky), but I do not think it is a good idea to leave a data racing bomb here... > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878127#comment-13878127 ] Hudson commented on HBASE-10087: FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #61 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/61/]) HBASE-10087 Store should be locked during a memstore snapshot (nkeywal: rev 1560018) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.1, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878098#comment-13878098 ] Hudson commented on HBASE-10087: FAILURE: Integrated in HBase-0.98 #100 (See [https://builds.apache.org/job/HBase-0.98/100/]) HBASE-10087 Store should be locked during a memstore snapshot (nkeywal: rev 1560028) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.1, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877625#comment-13877625 ] Hudson commented on HBASE-10087: FAILURE: Integrated in HBase-TRUNK #4843 (See [https://builds.apache.org/job/HBase-TRUNK/4843/]) HBASE-10087 Store should be locked during a memstore snapshot (nkeywal: rev 1560018) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.1, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877596#comment-13877596 ] Hudson commented on HBASE-10087: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #92 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/92/]) HBASE-10087 Store should be locked during a memstore snapshot (nkeywal: rev 1560028) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.1, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877494#comment-13877494 ] Nicolas Liochon commented on HBASE-10087: - Committed to trunk & 0.98, thanks for the review and the feedback, all. > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.1, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876822#comment-13876822 ] Andrew Purtell commented on HBASE-10087: +1 > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.1, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876631#comment-13876631 ] Nicolas Liochon commented on HBASE-10087: - It's just a comment change, TestHBaseFsck is likely flakky... > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.1, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[
https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876621#comment-13876621
]
Hadoop QA commented on HBASE-10087:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12623961/10087.v2.patch
against trunk revision .
ATTACHMENT ID: 12623961
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.util.TestHBaseFsck
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8474//console
This message is automatically generated.
> Store should be locked during a memstore snapshot
> -
>
> Key: HBASE-10087
> URL: https://issues.apache.org/jira/browse/HBASE-10087
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.98.0, 0.96.1, 0.94.14
>Reporter: Nicolas Liochon
>Assignee: Nicolas Liochon
> Fix For: 0.98.1, 0.99.0
>
> Attachments: 10079.v1.patch, 10087.v2.patch
>
>
> regression from HBASE-9963, found while looking at HBASE-10079.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876559#comment-13876559 ] stack commented on HBASE-10087: --- +1 > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.1, 0.99.0 > > Attachments: 10079.v1.patch, 10087.v2.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853044#comment-13853044 ] Nicolas Liochon commented on HBASE-10087: - Ok, I will do that :-) > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852691#comment-13852691 ] Anoop Sam John commented on HBASE-10087: We can close this issue just adding a code level comment saying we already have the lock and so not going for that. It will help others later.. :) > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850286#comment-13850286 ] Nicolas Liochon commented on HBASE-10087: - Thanks for the confirmation. Any opinion on adding the lock for consistency on trunk, or shall we close this jira? > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[
https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849215#comment-13849215
]
Nicolas Liochon commented on HBASE-10087:
-
Sorry for the delay.
Theoretically, we have an issue:
{code}
@Override
public void prepare() {
memstore.snapshot();
this.snapshot = memstore.getSnapshot();
this.snapshotTimeRangeTracker = memstore.getSnapshotTimeRangeTracker();
}
{code}
w/o a lock, we could have an inconsistency between the snapshot and the
snapshotTimeRangeTracker.
As well, we could have an inconsistency in memstore.snapshot();
But it seems it cannot happen, because:
Store#snaphot is called only in the tests.
Store#prepare is called with the write lock on the HRegion.
The functions that will modify the store also have the read lock on HRegion, so
we can't be inconsistent in practice.
This said, adding the lock in prepare() would be more consistent imho. I would
propose to add it on trunk.
> Store should be locked during a memstore snapshot
> -
>
> Key: HBASE-10087
> URL: https://issues.apache.org/jira/browse/HBASE-10087
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.98.0, 0.96.1, 0.94.14
>Reporter: Nicolas Liochon
>Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.96.1, 0.94.15
>
> Attachments: 10079.v1.patch
>
>
> regression from HBASE-9963, found while looking at HBASE-10079.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847952#comment-13847952 ] Lars Hofhansl commented on HBASE-10087: --- Any progress, by any chance? :) Want to cut 0.94.15RC0 soon'ish. We did lock before but on a different lock. So the only risk adding this here is a potential deadlock if we call this with the resp. readlock held. > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1, 0.94.15 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840535#comment-13840535 ] Nicolas Liochon commented on HBASE-10087: - We were locking before, so we're just adding back the lock. But I agree, we should be able to prove that we need this lock with a test... I will try. > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1, 0.94.15 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840463#comment-13840463 ] Lars Hofhansl commented on HBASE-10087: --- I meant: Can we close this? It does not appear to be an issue. :) > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1, 0.94.15 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840455#comment-13840455 ] Nicolas Liochon commented on HBASE-10087: - bq. HBASE-10079 now looks like a race in the tablename caching. Not related to the locking here. Yes, but the patch here was first ran there :-). > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1, 0.94.15 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840445#comment-13840445 ] Lars Hofhansl commented on HBASE-10087: --- HBASE-10079 now looks like a race in the tablename caching. Not related to the locking here. > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1, 0.94.15 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840389#comment-13840389 ] Nicolas Liochon commented on HBASE-10087: - bq. Are we sure we won't ever call this with the readlock held, would lead to an instance deadlock (rw lock does not support upgrading the lock). Asking because I see a lot of tests in that run that either did not run or did not finish. I will have a look. The tests ran ok in the HBASE-10079. bq. Maybe in 0.94 it's best to restore the old behavior...? I think it's safer to have the same code on the two branches: the tests on one version benefit to the other... > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1, 0.94.15 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840378#comment-13840378 ] Lars Hofhansl commented on HBASE-10087: --- lgtm Are we sure we won't ever call this with the readlock held, would lead to an instance deadlock (rw lock does not support upgrading the lock). Asking because I see a lot of tests in that run that either did not run or did not finish. > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1, 0.94.15 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840379#comment-13840379 ] Lars Hofhansl commented on HBASE-10087: --- Maybe in 0.94 it's best to restore the old behavior...? > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1, 0.94.15 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[ https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840048#comment-13840048 ] stack commented on HBASE-10087: --- +1 as long as the test fail is not related. > Store should be locked during a memstore snapshot > - > > Key: HBASE-10087 > URL: https://issues.apache.org/jira/browse/HBASE-10087 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.98.0, 0.96.1, 0.94.14 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.96.1, 0.94.15 > > Attachments: 10079.v1.patch > > > regression from HBASE-9963, found while looking at HBASE-10079. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HBASE-10087) Store should be locked during a memstore snapshot
[
https://issues.apache.org/jira/browse/HBASE-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840026#comment-13840026
]
Hadoop QA commented on HBASE-10087:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12617139/10079.v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8062//console
This message is automatically generated.
> Store should be locked during a memstore snapshot
> -
>
> Key: HBASE-10087
> URL: https://issues.apache.org/jira/browse/HBASE-10087
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.98.0, 0.96.1, 0.94.14
>Reporter: Nicolas Liochon
>Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.96.1, 0.94.15
>
> Attachments: 10079.v1.patch
>
>
> regression from HBASE-9963, found while looking at HBASE-10079.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
