[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848206#comment-13848206 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #5 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/5/]) HBASE-10116 Addendum: fix findbugs warning (ndimiduk: rev 1550522) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch, HBASE-10116.addendum.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847841#comment-13847841 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #7 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/7/]) HBASE-10116 Addendum: fix findbugs warning (ndimiduk: rev 1550523) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch, HBASE-10116.addendum.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847469#comment-13847469 ] Hudson commented on HBASE-10116: FAILURE: Integrated in hbase-0.96-hadoop2 #148 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/148/]) HBASE-10116 Addendum: fix findbugs warning (ndimiduk: rev 1550526) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch, HBASE-10116.addendum.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847358#comment-13847358 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in hbase-0.96 #224 (See [https://builds.apache.org/job/hbase-0.96/224/]) HBASE-10116 Addendum: fix findbugs warning (ndimiduk: rev 1550526) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch, HBASE-10116.addendum.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847353#comment-13847353 ] Hudson commented on HBASE-10116: FAILURE: Integrated in HBase-0.98 #9 (See [https://builds.apache.org/job/HBase-0.98/9/]) HBASE-10116 Addendum: fix findbugs warning (ndimiduk: rev 1550523) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch, HBASE-10116.addendum.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847327#comment-13847327 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in HBase-TRUNK #4721 (See [https://builds.apache.org/job/HBase-TRUNK/4721/]) HBASE-10116 Addendum: fix findbugs warning (ndimiduk: rev 1550522) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch, HBASE-10116.addendum.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[
https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846674#comment-13846674
]
Hadoop QA commented on HBASE-10116:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12618451/HBASE-10116.addendum.00.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8141//console
This message is automatically generated.
> SlabCache metrics improvements
> --
>
> Key: HBASE-10116
> URL: https://issues.apache.org/jira/browse/HBASE-10116
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 0.98.0, 0.96.2, 0.99.0
>
> Attachments: HBASE-10116.00.patch, HBASE-10116.addendum.00.patch
>
>
> SlabCache incorrectly reports block count and could do a better job reporting
> free size. MetricsRegionServerWrapperImpl incorrectly reports block cache
> count. Expose Direct Memory stats on RegionServer WebUI.
> Also clean up javadoc on BlockCache interface methods, and whitespace in
> cache-related classes.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846601#comment-13846601 ] Ted Yu commented on HBASE-10116: +1 > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch, HBASE-10116.addendum.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845968#comment-13845968 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in hbase-0.96-hadoop2 #147 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/147/]) HBASE-10116 SlabCache metrics improvements (ndimiduk: rev 1549937) * /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845868#comment-13845868 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #6 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/6/]) HBASE-10116 SlabCache metrics improvements (ndimiduk: rev 1549936) * /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845831#comment-13845831 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #4 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/4/]) HBASE-10116 SlabCache metrics improvements (ndimiduk: rev 1549935) * /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844991#comment-13844991 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in hbase-0.96 #221 (See [https://builds.apache.org/job/hbase-0.96/221/]) HBASE-10116 SlabCache metrics improvements (ndimiduk: rev 1549937) * /hbase/branches/0.96/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844959#comment-13844959 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in HBase-0.98 #7 (See [https://builds.apache.org/job/HBase-0.98/7/]) HBASE-10116 SlabCache metrics improvements (ndimiduk: rev 1549936) * /hbase/branches/0.98/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844937#comment-13844937 ] Hudson commented on HBASE-10116: SUCCESS: Integrated in HBase-TRUNK #4719 (See [https://builds.apache.org/job/HBase-TRUNK/4719/]) HBASE-10116 SlabCache metrics improvements (ndimiduk: rev 1549935) * /hbase/trunk/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844544#comment-13844544 ] Andrew Purtell commented on HBASE-10116: bq. This might be a point of confusion for users. I think that's fine as long as it is documented in the manual > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844542#comment-13844542 ] Nick Dimiduk commented on HBASE-10116: -- I'll point out that Oracle JDK6 (1.6.0_31 in my test) doesn't expose "java.nio:type=BufferPool,name=direct", so DirectMemoryUtils#getDirectMemoryUsage (and thus the change to rs-status#memoryStats) reports 0 on that environment. This might be a point of confusion for users. > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2, 0.99.0 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844533#comment-13844533 ] Elliott Clark commented on HBASE-10116: --- +1 the metrics changes look good thanks for catching that. > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844527#comment-13844527 ] Andrew Purtell commented on HBASE-10116: +1 > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[ https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844470#comment-13844470 ] Sergey Shelukhin commented on HBASE-10116: -- +1 > SlabCache metrics improvements > -- > > Key: HBASE-10116 > URL: https://issues.apache.org/jira/browse/HBASE-10116 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Minor > Fix For: 0.98.0, 0.96.2 > > Attachments: HBASE-10116.00.patch > > > SlabCache incorrectly reports block count and could do a better job reporting > free size. MetricsRegionServerWrapperImpl incorrectly reports block cache > count. Expose Direct Memory stats on RegionServer WebUI. > Also clean up javadoc on BlockCache interface methods, and whitespace in > cache-related classes. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10116) SlabCache metrics improvements
[
https://issues.apache.org/jira/browse/HBASE-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843908#comment-13843908
]
Hadoop QA commented on HBASE-10116:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12617949/HBASE-10116.00.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8112//console
This message is automatically generated.
> SlabCache metrics improvements
> --
>
> Key: HBASE-10116
> URL: https://issues.apache.org/jira/browse/HBASE-10116
> Project: HBase
> Issue Type: Improvement
> Components: metrics, regionserver
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 0.98.0, 0.96.2
>
> Attachments: HBASE-10116.00.patch
>
>
> SlabCache incorrectly reports block count and could do a better job reporting
> free size. MetricsRegionServerWrapperImpl incorrectly reports block cache
> count. Expose Direct Memory stats on RegionServer WebUI.
> Also clean up javadoc on BlockCache interface methods, and whitespace in
> cache-related classes.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
