[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[ https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862744#comment-13862744 ] takeshi.miao commented on HBASE-10154: -- hi [~stack] I can wait for HBASE-10147 and revise this patch due to these two patches have some conflicts need to be resolved. > Add a unit test for Canary tool > --- > > Key: HBASE-10154 > URL: https://issues.apache.org/jira/browse/HBASE-10154 > Project: HBase > Issue Type: Improvement > Components: monitoring, test >Reporter: takeshi.miao >Assignee: takeshi.miao >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10154-trunk-v01.patch, > HBASE-10154-trunk-v02.patch, HBASE-10154-trunk-v03.patch > > > Due to HBASE-10108, I am working to come out a unit test for > o.h.hbase.tool.Canary to eliminate this kind of issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[
https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860982#comment-13860982
]
Hadoop QA commented on HBASE-10154:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621036/HBASE-10154-trunk-v03.patch
against trunk revision .
ATTACHMENT ID: 12621036
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8314//console
This message is automatically generated.
> Add a unit test for Canary tool
> ---
>
> Key: HBASE-10154
> URL: https://issues.apache.org/jira/browse/HBASE-10154
> Project: HBase
> Issue Type: Improvement
> Components: monitoring, test
>Reporter: takeshi.miao
>Assignee: takeshi.miao
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: HBASE-10154-trunk-v01.patch,
> HBASE-10154-trunk-v02.patch, HBASE-10154-trunk-v03.patch
>
>
> Due to HBASE-10108, I am working to come out a unit test for
> o.h.hbase.tool.Canary to eliminate this kind of issue.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[ https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860009#comment-13860009 ] takeshi.miao commented on HBASE-10154: -- @stack a quick update, I found the issue then would update a new patch v03 today. tks for your help~ > Add a unit test for Canary tool > --- > > Key: HBASE-10154 > URL: https://issues.apache.org/jira/browse/HBASE-10154 > Project: HBase > Issue Type: Improvement > Components: monitoring, test >Reporter: takeshi.miao >Assignee: takeshi.miao >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10154-trunk-v01.patch, HBASE-10154-trunk-v02.patch > > > Due to HBASE-10108, I am working to come out a unit test for > o.h.hbase.tool.Canary to eliminate this kind of issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[ https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859271#comment-13859271 ] takeshi.miao commented on HBASE-10154: -- [~stack] tks for your comments, I'd like to take more times to work on this issue more details if you don't mind, due to I have more time to deal with it in these couple days; I will update or call your help if I still can not deal with it. tks and happy new year :) > Add a unit test for Canary tool > --- > > Key: HBASE-10154 > URL: https://issues.apache.org/jira/browse/HBASE-10154 > Project: HBase > Issue Type: Improvement > Components: monitoring, test >Reporter: takeshi.miao >Assignee: takeshi.miao >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10154-trunk-v01.patch, HBASE-10154-trunk-v02.patch > > > Due to HBASE-10108, I am working to come out a unit test for > o.h.hbase.tool.Canary to eliminate this kind of issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[ https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858393#comment-13858393 ] stack commented on HBASE-10154: --- [~takeshi.miao] That might not be an issue -- the stacktrace you paste. Is that just a noisy log reporting a region is not where the canary thinks it is? And on retry, the canary finds the region in its new location? Or are you seeing it fail? If you paste full log I can take a looksee. The original exception I posted is more fundamental, as though the test did not run at all. I did not dig in. I could if you would like some pointers. Just say. > Add a unit test for Canary tool > --- > > Key: HBASE-10154 > URL: https://issues.apache.org/jira/browse/HBASE-10154 > Project: HBase > Issue Type: Improvement > Components: monitoring, test >Reporter: takeshi.miao >Assignee: takeshi.miao >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10154-trunk-v01.patch, HBASE-10154-trunk-v02.patch > > > Due to HBASE-10108, I am working to come out a unit test for > o.h.hbase.tool.Canary to eliminate this kind of issue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[
https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858387#comment-13858387
]
takeshi.miao commented on HBASE-10154:
--
[~stack] yes, the same issue also occurs at my dev PC and I need to say sorry
for confusing you
I am still working on this and suffer following issue while I test it in both
Maven and Eclipse, detail as follows...
1. This test ran smoothly at old trunk about (2 weeks ago)
2. Then I patched it with the newest trunk and issue occurring...
2.1 If I run it with _'mvn clean test -Dtest=TestCanary'_, will show the same
error as you menthioned
2.2 If I run it with Eclipse, then it would pass about two test methods and
then stop suddenly, show following error msg
{code}
...
2013-12-30 02:10:08,103 DEBUG [RpcServer.handler=2,port=46717]
ipc.CallRunner(95): RpcServer.handler=2,port=46717: callId: 89 service:
ClientService methodName: Scan size: 93 connection: 10.1.148.59:33908
org.apache.hadoop.hbase.NotServingRegionException: Region
test-01,,1388340602777.fd859be55ffe07136dab281be1685f0a. is not online
at
org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:2661)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:4060)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.scan(HRegionServer.java:3059)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:28454)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2008)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:92)
at
org.apache.hadoop.hbase.ipc.SimpleRpcScheduler.consumerLoop(SimpleRpcScheduler.java:160)
at
org.apache.hadoop.hbase.ipc.SimpleRpcScheduler.access$000(SimpleRpcScheduler.java:38)
at
org.apache.hadoop.hbase.ipc.SimpleRpcScheduler$1.run(SimpleRpcScheduler.java:110)
at java.lang.Thread.run(Thread.java:662)
{code}
I am not sure it whether the root cause and still under investigation
currently...I will appreciate it if you have any idea about it...
> Add a unit test for Canary tool
> ---
>
> Key: HBASE-10154
> URL: https://issues.apache.org/jira/browse/HBASE-10154
> Project: HBase
> Issue Type: Improvement
> Components: monitoring, test
>Reporter: takeshi.miao
>Assignee: takeshi.miao
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: HBASE-10154-trunk-v01.patch, HBASE-10154-trunk-v02.patch
>
>
> Due to HBASE-10108, I am working to come out a unit test for
> o.h.hbase.tool.Canary to eliminate this kind of issue.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[
https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857622#comment-13857622
]
stack commented on HBASE-10154:
---
The test 'passes' but it still does this:
{code}
Running org.apache.hadoop.hbase.tool.TestCanary
2013-12-27 10:34:47.948 java[1431:1003] Unable to load realm info from
SCDynamicStore
org.apache.maven.surefire.booter.SurefireBooterForkException: Error occurred in
starting fork, check output in log
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:238)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$000(ForkStarter.java:64)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter$ParallelFork.call(ForkStarter.java:303)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter$ParallelFork.call(ForkStarter.java:285)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:695)
No results for java.util.concurrent.FutureTask@1e7c6da0
Results :
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
{code}
...with patch v2. Does it work for you [~takeshi.miao]
> Add a unit test for Canary tool
> ---
>
> Key: HBASE-10154
> URL: https://issues.apache.org/jira/browse/HBASE-10154
> Project: HBase
> Issue Type: Improvement
> Components: monitoring, test
>Reporter: takeshi.miao
>Assignee: takeshi.miao
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: HBASE-10154-trunk-v01.patch, HBASE-10154-trunk-v02.patch
>
>
> Due to HBASE-10108, I am working to come out a unit test for
> o.h.hbase.tool.Canary to eliminate this kind of issue.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[ https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853592#comment-13853592 ] takeshi.miao commented on HBASE-10154: -- [~stack] tks for review, this test fails after I patched it with newest trunk codes; Currently working on this, will submit new patch later. > Add a unit test for Canary tool > --- > > Key: HBASE-10154 > URL: https://issues.apache.org/jira/browse/HBASE-10154 > Project: HBase > Issue Type: Improvement > Components: monitoring, test >Reporter: takeshi.miao >Assignee: takeshi.miao >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10154-trunk-v01.patch, HBASE-10154-trunk-v02.patch > > > Due to HBASE-10108, I am working to come out a unit test for > o.h.hbase.tool.Canary to eliminate this kind of issue. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[
https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853120#comment-13853120
]
stack commented on HBASE-10154:
---
I tried it and got this:
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.tool.TestCanary
2013-12-19 10:29:35.168 java[59546:1003] Unable to load realm info from
SCDynamicStore
org.apache.maven.surefire.booter.SurefireBooterForkException: Error occurred in
starting fork, check output in log
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:238)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$000(ForkStarter.java:64)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter$ParallelFork.call(ForkStarter.java:303)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter$ParallelFork.call(ForkStarter.java:285)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:695)
No results for java.util.concurrent.FutureTask@1100d290
Results :
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
{code}
No tests ran and I got the above output.
Did I do it wrong [~takeshi.miao] Thanks.
> Add a unit test for Canary tool
> ---
>
> Key: HBASE-10154
> URL: https://issues.apache.org/jira/browse/HBASE-10154
> Project: HBase
> Issue Type: Improvement
> Components: monitoring, test
>Reporter: takeshi.miao
>Assignee: takeshi.miao
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: HBASE-10154-trunk-v01.patch, HBASE-10154-trunk-v02.patch
>
>
> Due to HBASE-10108, I am working to come out a unit test for
> o.h.hbase.tool.Canary to eliminate this kind of issue.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[
https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852720#comment-13852720
]
Hadoop QA commented on HBASE-10154:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12619498/HBASE-10154-trunk-v02.patch
against trunk revision .
ATTACHMENT ID: 12619498
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8228//console
This message is automatically generated.
> Add a unit test for Canary tool
> ---
>
> Key: HBASE-10154
> URL: https://issues.apache.org/jira/browse/HBASE-10154
> Project: HBase
> Issue Type: Improvement
> Components: monitoring, test
>Reporter: takeshi.miao
>Assignee: takeshi.miao
>Priority: Minor
> Fix For: 0.99.0
>
> Attachments: HBASE-10154-trunk-v01.patch, HBASE-10154-trunk-v02.patch
>
>
> Due to HBASE-10108, I am working to come out a unit test for
> o.h.hbase.tool.Canary to eliminate this kind of issue.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[ https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852677#comment-13852677 ] takeshi.miao commented on HBASE-10154: -- upload patch-v02 for trunk and wait to see QA results > Add a unit test for Canary tool > --- > > Key: HBASE-10154 > URL: https://issues.apache.org/jira/browse/HBASE-10154 > Project: HBase > Issue Type: Improvement > Components: monitoring, test >Reporter: takeshi.miao >Assignee: takeshi.miao >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10154-trunk-v01.patch, HBASE-10154-trunk-v02.patch > > > Due to HBASE-10108, I am working to come out a unit test for > o.h.hbase.tool.Canary to eliminate this kind of issue. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HBASE-10154) Add a unit test for Canary tool
[ https://issues.apache.org/jira/browse/HBASE-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847236#comment-13847236 ] takeshi.miao commented on HBASE-10154: -- The later version, I plan to do... 1. more tests for covering different kind of options combinations. 2. use _'ExtendedSink' interface_ to do the mock impl. for verifying the Canary output results. > Add a unit test for Canary tool > --- > > Key: HBASE-10154 > URL: https://issues.apache.org/jira/browse/HBASE-10154 > Project: HBase > Issue Type: Improvement > Components: monitoring, test >Reporter: takeshi.miao >Assignee: takeshi.miao >Priority: Minor > Attachments: HBASE-10154-trunk-v01.patch > > > Due to HBASE-10108, I am working to come out a unit test for > o.h.hbase.tool.Canary to eliminate this kind of issue. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
