[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868719#comment-13868719 ] chendihao commented on HBASE-10306: --- Thanks for the review. [~lhofhansl] [~enis] > Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() > - > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867476#comment-13867476 ] Hudson commented on HBASE-10306: SUCCESS: Integrated in HBase-0.94 #1258 (See [https://builds.apache.org/job/HBase-0.94/1258/]) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() > - > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867471#comment-13867471 ] Hudson commented on HBASE-10306: FAILURE: Integrated in HBase-0.94-JDK7 #25 (See [https://builds.apache.org/job/HBase-0.94-JDK7/25/]) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() > - > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867457#comment-13867457 ] Hudson commented on HBASE-10306: SUCCESS: Integrated in HBase-0.94-security #386 (See [https://builds.apache.org/job/HBase-0.94-security/386/]) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java > Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() > - > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867417#comment-13867417 ] Lars Hofhansl commented on HBASE-10306: --- Thanks [~tobe]. > Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() > - > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867390#comment-13867390 ] Enis Soztutar commented on HBASE-10306: --- bq. Let's commit the patch as is. Will do so unless I hear objections. +1. > Backport HBASE-6820 to 0.94 > --- > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.3, 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867385#comment-13867385 ] Lars Hofhansl commented on HBASE-10306: --- I see. Let's commit the patch as is. Will do so unless I hear objections. > Backport HBASE-6820 to 0.94 > --- > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.3, 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867342#comment-13867342 ] Enis Soztutar commented on HBASE-10306: --- See also: HBASE-10274 > Backport HBASE-6820 to 0.94 > --- > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.3, 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867340#comment-13867340 ] Enis Soztutar commented on HBASE-10306: --- bq. Is this part needed? I think that part comes from the original patch. That is needed for an early-exit strategy if the directory cannot be cleaned (in case open file handlers for example). But we can live without that as well. Other than that +1 from me. > Backport HBASE-6820 to 0.94 > --- > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.3, 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867143#comment-13867143 ] Lars Hofhansl commented on HBASE-10306: --- [~tobe]? > Backport HBASE-6820 to 0.94 > --- > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Fix For: 0.94.3, 0.94.16 > > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94
[
https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866779#comment-13866779
]
Lars Hofhansl commented on HBASE-10306:
---
Is this part needed?
{code}
- FileUtil.fullyDelete(dir);
+ if(!FileUtil.fullyDelete(dir)) {
+throw new IOException("Could not delete zk base directory: " + dir);
+ }
{code}
Would is negatively affect some tests?
> Backport HBASE-6820 to 0.94
> ---
>
> Key: HBASE-10306
> URL: https://issues.apache.org/jira/browse/HBASE-10306
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.94.3
>Reporter: chendihao
>Assignee: chendihao
>Priority: Minor
> Fix For: 0.94.3, 0.94.16
>
> Attachments: HBASE-10306-0.94-v1.patch
>
>
> Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that
> ZKDatabase is closed upon shutdown()
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94
[
https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866420#comment-13866420
]
Hadoop QA commented on HBASE-10306:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12622127/HBASE-10306-0.94-v1.patch
against trunk revision .
ATTACHMENT ID: 12622127
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8375//console
This message is automatically generated.
> Backport HBASE-6820 to 0.94
> ---
>
> Key: HBASE-10306
> URL: https://issues.apache.org/jira/browse/HBASE-10306
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.94.3
>Reporter: chendihao
>Assignee: chendihao
>Priority: Minor
> Fix For: 0.94.3, 0.94.16
>
> Attachments: HBASE-10306-0.94-v1.patch
>
>
> Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that
> ZKDatabase is closed upon shutdown()
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10306) Backport HBASE-6820 to 0.94
[ https://issues.apache.org/jira/browse/HBASE-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866402#comment-13866402 ] chendihao commented on HBASE-10306: --- The patch is recreated for the newest code of 0.94. [~enis] please review. > Backport HBASE-6820 to 0.94 > --- > > Key: HBASE-10306 > URL: https://issues.apache.org/jira/browse/HBASE-10306 > Project: HBase > Issue Type: Bug >Affects Versions: 0.94.3 >Reporter: chendihao >Assignee: chendihao >Priority: Minor > Attachments: HBASE-10306-0.94-v1.patch > > > Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that > ZKDatabase is closed upon shutdown() -- This message was sent by Atlassian JIRA (v6.1.5#6160)
