[jira] [Commented] (HBASE-10532) Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
[
https://issues.apache.org/jira/browse/HBASE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919297#comment-13919297
]
Hadoop QA commented on HBASE-10532:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12632483/HBASE-10532_2.patch
against trunk revision .
ATTACHMENT ID: 12632483
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static int compareRowsWithCommonFamilyPrefix(Cell left, Cell
right, int familyCommonPrefix) {
+ public static int compareRowsWithQualifierFamilyPrefix(Cell left, Cell
right, int qualCommonPrefix) {
+ public static int findCommonPrefixInQualifierPart(Cell left, Cell right, int
qualifierCommonPrefix) {
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8877//console
This message is automatically generated.
> Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
> ---
>
> Key: HBASE-10532
> URL: https://issues.apache.org/jira/browse/HBASE-10532
> Project: HBase
> Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10532.patch, HBASE-10532.patch, HBASE-10532_2.patch
>
>
> public int compareRows(final KeyValue left, final KeyValue right)
> public boolean matchingRows(final KeyValue left, final KeyValue right)
> We can make them to use Cells instead of KeyValue incase we need to use them
> for comparison of any type of cell in future.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10532) Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905085#comment-13905085 ] ramkrishna.s.vasudevan commented on HBASE-10532: We already have a CellComparator introduced for Prefixtree. Infact compareStaticIgnoreMvccVersion() in CellComparator can be used to compare the flat keys incase of seekTo, reseekTo, seekBefore. May be I will add the required comparators to the existing Cellcomparator. > Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue. > --- > > Key: HBASE-10532 > URL: https://issues.apache.org/jira/browse/HBASE-10532 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10532.patch, HBASE-10532.patch > > > public int compareRows(final KeyValue left, final KeyValue right) > public boolean matchingRows(final KeyValue left, final KeyValue right) > We can make them to use Cells instead of KeyValue incase we need to use them > for comparison of any type of cell in future. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10532) Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904828#comment-13904828 ] Nick Dimiduk commented on HBASE-10532: -- bq. Shall we do a CellComparator, which will not have any KV bits, and start using that internally? +1 > Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue. > --- > > Key: HBASE-10532 > URL: https://issues.apache.org/jira/browse/HBASE-10532 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10532.patch, HBASE-10532.patch > > > public int compareRows(final KeyValue left, final KeyValue right) > public boolean matchingRows(final KeyValue left, final KeyValue right) > We can make them to use Cells instead of KeyValue incase we need to use them > for comparison of any type of cell in future. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10532) Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904774#comment-13904774 ] stack commented on HBASE-10532: --- I like suggestion of adding a CellComparator and using it internally. It underlines the direction we are heading in. Patch looks good. > Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue. > --- > > Key: HBASE-10532 > URL: https://issues.apache.org/jira/browse/HBASE-10532 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10532.patch, HBASE-10532.patch > > > public int compareRows(final KeyValue left, final KeyValue right) > public boolean matchingRows(final KeyValue left, final KeyValue right) > We can make them to use Cells instead of KeyValue incase we need to use them > for comparison of any type of cell in future. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10532) Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
[ https://issues.apache.org/jira/browse/HBASE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904765#comment-13904765 ] Enis Soztutar commented on HBASE-10532: --- This looks good. In matchingRowColumn() we can just call compareRows() and compareColumns() directly. Just a suggestion. Shall we do a CellComparator, which will not have any KV bits, and start using that internally? What do you think. > Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue. > --- > > Key: HBASE-10532 > URL: https://issues.apache.org/jira/browse/HBASE-10532 > Project: HBase > Issue Type: Sub-task >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan > Fix For: 0.99.0 > > Attachments: HBASE-10532.patch, HBASE-10532.patch > > > public int compareRows(final KeyValue left, final KeyValue right) > public boolean matchingRows(final KeyValue left, final KeyValue right) > We can make them to use Cells instead of KeyValue incase we need to use them > for comparison of any type of cell in future. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10532) Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
[
https://issues.apache.org/jira/browse/HBASE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903148#comment-13903148
]
Hadoop QA commented on HBASE-10532:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629327/HBASE-10532.patch
against trunk revision .
ATTACHMENT ID: 12629327
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ int diff = compareFamilies(left.getFamilyArray(), lfoffset,
lfamilylength, right.getFamilyArray(), rfoffset, rfamilylength);
+protected int compareFamilies(final byte[] left, final int loffset, final
int lfamilylength, final byte[] right,
+protected int compareColumns(final byte[] left, final int loffset, final
int lquallength, final byte[] right,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testLogRollOnDatanodeDeath(TestLogRolling.java:354)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8728//console
This message is automatically generated.
> Make KeyValueComparator in KeyValue to accept Cell instead of KeyValue.
> ---
>
> Key: HBASE-10532
> URL: https://issues.apache.org/jira/browse/HBASE-10532
> Project: HBase
> Issue Type: Sub-task
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.99.0
>
> Attachments: HBASE-10532.patch, HBASE-10532.patch
>
>
> public int compareRows(final KeyValue left, final KeyValue right)
> public boolean matchingRows(final KeyValue left, final KeyValue right)
> We can make them to use Cells instead of KeyValue incase we need to use them
> for comparison of any type of cell in future.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
