[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981318#comment-13981318 ] Enis Soztutar commented on HBASE-10581: --- Ok thanks. Just wanted to make sure that there is not any other issue. ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979527#comment-13979527 ] Qiang Tian commented on HBASE-10581: Paste the stacktrace so user is easier to get here. thanks. --- org.apache.hadoop.hbase.security.access.HbaseObjectWritableFor96Migration: Error in readFields java.io.EOFException at java.io.DataInputStream.readBoolean(DataInputStream.java:238) at org.apache.hadoop.hbase.security.access.TablePermission.readFields (TablePermission.java:397) at org.apache.hadoop.hbase.security.access.HbaseObjectWritableFor96Migration.readObject (HbaseObjectWritableFor96Migration.java:689) at org.apache.hadoop.hbase.security.access.HbaseObjectWritableFor96Migration.readObject (HbaseObjectWritableFor96Migration.java:589) at org.apache.hadoop.hbase.security.access.HbaseObjectWritableFor96Migration.readObject (HbaseObjectWritableFor96Migration.java:650) at org.apache.hadoop.hbase.security.access.HbaseObjectWritableFor96Migration.readObject (HbaseObjectWritableFor96Migration.java:589) at org.apache.hadoop.hbase.security.access.AccessControlLists.readPermissions (AccessControlLists.java:614) at org.apache.hadoop.hbase.security.access.TableAuthManager.refreshTableCacheFromWritable (TableAuthManager.java:158) at org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.refreshAuthManager (ZKPermissionWatcher.java:152) at org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.refreshNodes (ZKPermissionWatcher.java:135) at org.apache.hadoop.hbase.security.access.ZKPermissionWatcher.start (ZKPermissionWatcher.java:64) at org.apache.hadoop.hbase.security.access.TableAuthManager.init (TableAuthManager.java:114) at org.apache.hadoop.hbase.security.access.TableAuthManager.get (TableAuthManager.java:662) at org.apache.hadoop.hbase.security.access.AccessController.start (AccessController.java:525) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$Environment.startup (CoprocessorHost.java:634) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadInstance (CoprocessorHost.java:258) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors (CoprocessorHost.java:158) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.init (MasterCoprocessorHost.java:69) at org.apache.hadoop.hbase.master.HMaster.finishInitialization (HMaster.java:827) at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:612) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980019#comment-13980019 ] Enis Soztutar commented on HBASE-10581: --- [~tianq] is this trace before applying this patch? ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980593#comment-13980593 ] Qiang Tian commented on HBASE-10581: hi [~enis], yes, it is. ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911528#comment-13911528 ] Hudson commented on HBASE-10581: FAILURE: Integrated in hbase-0.96-hadoop2 #215 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/215/]) HBASE-10581: ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ (jeffreyz: rev 1571523) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/ZKDataMigrator.java ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13912402#comment-13912402 ] Hudson commented on HBASE-10581: FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #99 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/99/]) HBASE-10581: ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ (jeffreyz: rev 1571519) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/ZKDataMigrator.java ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911231#comment-13911231 ] Hudson commented on HBASE-10581: SUCCESS: Integrated in HBase-0.98 #182 (See [https://builds.apache.org/job/HBase-0.98/182/]) HBASE-10581: ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ (jeffreyz: rev 1571520) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/ZKDataMigrator.java ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911240#comment-13911240 ] Hudson commented on HBASE-10581: FAILURE: Integrated in hbase-0.96 #312 (See [https://builds.apache.org/job/hbase-0.96/312/]) HBASE-10581: ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ (jeffreyz: rev 1571523) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/util/ZKDataMigrator.java ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911255#comment-13911255 ] Hudson commented on HBASE-10581: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #170 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/170/]) HBASE-10581: ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ (jeffreyz: rev 1571520) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/ZKDataMigrator.java ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13911352#comment-13911352 ] Hudson commented on HBASE-10581: FAILURE: Integrated in HBase-TRUNK #4951 (See [https://builds.apache.org/job/HBase-TRUNK/4951/]) HBASE-10581: ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ (jeffreyz: rev 1571519) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/ZKDataMigrator.java ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Fix For: 0.96.2, 0.98.1, 0.99.0 Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908326#comment-13908326 ] Ted Yu commented on HBASE-10581: +1 ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908658#comment-13908658 ] Andrew Purtell commented on HBASE-10581: Can we modify this patch to do Himanshu's suggestion? bq. add a deleteRecursive call at the end of all these conditional checks ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[
https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908695#comment-13908695
]
Jeffrey Zhong commented on HBASE-10581:
---
{quote}
Can we modify this patch to do Himanshu's suggestion? add a deleteRecursive
call at the end of all these conditional checks
{quote}
I'm worried that if a customer has their own custom znodes. Cleaning the data
we don't know may cause data loss for them if they're not aware of this side
effect. Even sideline those znodes, it will also cause pain for them to move
them back. So far all znodes we know are covered after the fix. Therefore,
unknown znodes if there is any mostly likely are users data.
IMHO, it's better to be conservative to work on data that we know.
ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
-
Key: HBASE-10581
URL: https://issues.apache.org/jira/browse/HBASE-10581
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.0, 0.96.0, 0.96.1
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Critical
Attachments: hbase-10581.patch
ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+
Those 0.94 znodes will choke HMaster because their data aren't PBed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908709#comment-13908709 ] stack commented on HBASE-10581: --- +1 for 0.96 ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908734#comment-13908734 ] Himanshu Vashishtha commented on HBASE-10581: - Okay, sounds good Jeffrey. Thanks ! ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908764#comment-13908764 ] Jeffrey Zhong commented on HBASE-10581: --- Cool. If there is no objection, I'll check the fix in by end of today. Thanks. ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908935#comment-13908935 ] Andrew Purtell commented on HBASE-10581: I am -0 on this patch (not an objection strictly speaking) without Himanshu's suggestion. bq. I'm worried that if a customer has their own custom znodes. It's kind of crazy to even tacitly support customers writing their own custom znodes under /hbase , right? ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[
https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909061#comment-13909061
]
Jeffrey Zhong commented on HBASE-10581:
---
{quote}
It's kind of crazy to even tacitly support customers writing their own custom
znodes under /hbase , right?
{quote}
It sounds crazy but never under estimate our users' innovation here. In
addition, cleaning data without knowing what it is also seems a bit dangerous.
I'll wait more time to see if other more folks want to delete unknown znodes at
the end. If that's the case, I'll amend the patch otherwise I'll check the
current version early next week. Thanks for the reviews feedbacks.
ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
-
Key: HBASE-10581
URL: https://issues.apache.org/jira/browse/HBASE-10581
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.0, 0.96.0, 0.96.1
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Critical
Attachments: hbase-10581.patch
ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+
Those 0.94 znodes will choke HMaster because their data aren't PBed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909090#comment-13909090 ] Himanshu Vashishtha commented on HBASE-10581: - Yeah, I okay'ed it in my last comment considering such odd usages… But IMHO, any non-hbase process creating arbitrary znodes under /hbase doesn't sound right. If we treat it similar to creating arbitrary files in hbase directory, then a recursive delete of such znodes is the right option (and doc it accordingly in the book). Having said that, I am still okay if we don't delete them. :) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909216#comment-13909216 ] stack commented on HBASE-10581: --- Thanks [~himan...@cloudera.com] for being easy. Agree w/ [~jeffreyz] on the never underestimate the user's 'imagination'. Suggest we commit this, conservative, fix for now and move on. ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907824#comment-13907824 ] Jeffrey Zhong commented on HBASE-10581: --- We can remove them because start cluster will re-populate them after upgrade. ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907830#comment-13907830 ] Andrew Purtell commented on HBASE-10581: Yes an upgrade script should just delete these znodes. They are only a cache of persisted data. This can be documented. Related question is why can't all ZK znodes be cleared before upgrade? Probable answer: Replication. But that is the subject of another JIRA. :-) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907883#comment-13907883 ] Enis Soztutar commented on HBASE-10581: --- Marking this critical. +1 on deleting the znodes from the script ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907894#comment-13907894 ] Himanshu Vashishtha commented on HBASE-10581: - +1 Since we already handling znodes we would like to persist (replication, table state, etc), should we just add a deleteRecursive call at the end of all these conditional checks? ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[
https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907958#comment-13907958
]
Hadoop QA commented on HBASE-10581:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12630233/hbase-10581.patch
against trunk revision .
ATTACHMENT ID: 12630233
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8763//console
This message is automatically generated.
ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
-
Key: HBASE-10581
URL: https://issues.apache.org/jira/browse/HBASE-10581
Project: HBase
Issue Type: Bug
Affects Versions: 0.98.0, 0.96.0, 0.96.1
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Priority: Critical
Attachments: hbase-10581.patch
ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+
Those 0.94 znodes will choke HMaster because their data aren't PBed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907979#comment-13907979 ] Devaraj Das commented on HBASE-10581: - This was an unpleasant surprise at a customer site. +1 for the patch. ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10581) ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+
[ https://issues.apache.org/jira/browse/HBASE-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907985#comment-13907985 ] rajeshbabu commented on HBASE-10581: +1 ACL znode are left without PBed during upgrading hbase0.94* to hbase0.96+ - Key: HBASE-10581 URL: https://issues.apache.org/jira/browse/HBASE-10581 Project: HBase Issue Type: Bug Affects Versions: 0.98.0, 0.96.0, 0.96.1 Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Priority: Critical Attachments: hbase-10581.patch ACL znodes are left in the upgrade process when upgrading 0.94 to 0.96+ Those 0.94 znodes will choke HMaster because their data aren't PBed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
