[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046764#comment-14046764 ] Hudson commented on HBASE-10634: FAILURE: Integrated in HBase-TRUNK #5245 (See [https://builds.apache.org/job/HBase-TRUNK/5245/]) HBASE-10634 Multiget doesn't fully work (enis: rev 61bce903626cfe775e7b2df32b46568bbc6fe6bd) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: 0.99.0, hbase-10070 > > Attachments: 0032-HBASE-10634-Multiget-doesn-t-fully-work.patch, > 10634-1.1.txt, 10634-1.txt, HBASE-10634.02.patch, HBASE-10634.patch, > HBASE-10634.patch, multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046680#comment-14046680 ] Enis Soztutar commented on HBASE-10634: --- Committed to master as part of hbase-10070 branch merge > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: 0.99.0, hbase-10070 > > Attachments: 0032-HBASE-10634-Multiget-doesn-t-fully-work.patch, > 10634-1.1.txt, 10634-1.txt, HBASE-10634.02.patch, HBASE-10634.patch, > HBASE-10634.patch, multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046632#comment-14046632 ] Enis Soztutar commented on HBASE-10634: --- Attaching rebased patch for master that is committed > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 0032-HBASE-10634-Multiget-doesn-t-fully-work.patch, > 10634-1.1.txt, 10634-1.txt, HBASE-10634.02.patch, HBASE-10634.patch, > HBASE-10634.patch, multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964098#comment-13964098 ] Enis Soztutar commented on HBASE-10634: --- HBASE-10701 which was blocking this is committed. > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 10634-1.1.txt, 10634-1.txt, HBASE-10634.02.patch, > HBASE-10634.patch, HBASE-10634.patch, multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941072#comment-13941072 ] Devaraj Das commented on HBASE-10634: - [~sershe], you got confused :-) The combined patch will be the one with HBASE-10794. > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 10634-1.1.txt, 10634-1.txt, HBASE-10634.02.patch, > HBASE-10634.patch, HBASE-10634.patch, multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941014#comment-13941014 ] Sergey Shelukhin commented on HBASE-10634: -- Wait, this is not the combined patch > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 10634-1.1.txt, 10634-1.txt, HBASE-10634.02.patch, > HBASE-10634.patch, HBASE-10634.patch, multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941005#comment-13941005 ] Sergey Shelukhin commented on HBASE-10634: -- +1 for combined patch. Also improves some confusing logging... > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 10634-1.1.txt, 10634-1.txt, HBASE-10634.02.patch, > HBASE-10634.patch, HBASE-10634.patch, multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[
https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926132#comment-13926132
]
Devaraj Das commented on HBASE-10634:
-
The test on HBASE-10616 (without chaosmonkey yet) fails with 'read-failures'
with the latest patch.
{noformat}
2175, READ FAILURES=24, get_timeouts=24
2014-03-10 12:23:07,675 INFO [Thread-55] util.MultiThreadedAction: [R:40]
Keys=7266500, cols=86.5 M, time=00:19:27 Overall: [keys/s= 6223, latency=5 ms]
Current: [keys/s=6500, latency=5 ms], verified=7263964, READ FAILURES=24,
get_timeouts=24
{noformat}
I don't see any other exceptions (which is good). Here is the command I am
running if you want to repro:
{noformat}
bin/hbase
org.apache.hadoop.hbase.test.IntegrationTestTimeBoundedMultiGetRequestsWithRegionReplicas
-DIntegrationTestTimeBoundedMultiGetRequestsWithRegionReplicas.num_write_threads=40
-DIntegrationTestTimeBoundedMultiGetRequestsWithRegionReplicas.num_read_threads=40
-DIntegrationTestTimeBoundedMultiGetRequestsWithRegionReplicas.multigetBatchSize=500
-DIntegrationTestTimeBoundedMultiGetRequestsWithRegionReplicas.num_keys_per_server=3000
-DIntegrationTestTimeBoundedMultiGetRequestsWithRegionReplicas.num_regions_per_server=30
-Dhbase.ipc.client.allowsInterrupt=true
-DIntegrationTestTimeBoundedMultiGetRequestsWithRegionReplicas.tn=loadtestReplication31
-DIntegrationTestTimeBoundedMultiGetRequestsWithRegionReplicas.region_replication=2
{noformat}
> Multiget doesn't fully work
> ---
>
> Key: HBASE-10634
> URL: https://issues.apache.org/jira/browse/HBASE-10634
> Project: HBase
> Issue Type: Sub-task
>Reporter: Devaraj Das
>Assignee: Sergey Shelukhin
> Fix For: hbase-10070
>
> Attachments: 10634-1.txt, HBASE-10634.02.patch, HBASE-10634.patch,
> HBASE-10634.patch, multi.out, no-multi.out
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924101#comment-13924101 ] Devaraj Das commented on HBASE-10634: - [~sershe], let me run some tests... BTW did you notice my earlier comment on the latency increase with multi-get. Seems like something to debug. I don't know if your latest patch looks at that as well. > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 10634-1.txt, HBASE-10634.02.patch, HBASE-10634.patch, > HBASE-10634.patch, multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924097#comment-13924097 ] Sergey Shelukhin commented on HBASE-10634: -- Are we ok to commit this to branch? > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 10634-1.txt, HBASE-10634.02.patch, HBASE-10634.patch, > HBASE-10634.patch, multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922946#comment-13922946 ] Sergey Shelukhin commented on HBASE-10634: -- I think I can actually get rid of end conversion, let me try > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 10634-1.txt, HBASE-10634.patch, HBASE-10634.patch, > multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917598#comment-13917598 ] Sergey Shelukhin commented on HBASE-10634: -- Hmm... let me try to repro tomorrow. I think there might be a straightforward race between setting action counter and notifying the waiting thread, and conversion; probably some sync is necessary. So conversion is done but the other thread sees unconverted result... But I'm not sure now. Maybe error should be put in front of the function, still, to make sure we don't get extra calls now. > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 10634-1.txt, HBASE-10634.patch, HBASE-10634.patch, > multi.out, no-multi.out > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915399#comment-13915399 ] Sergey Shelukhin commented on HBASE-10634: -- all of these look like incorrect calls to decActionCounters - too many calls for 1-2, and too few calls(?) for 3. It should be called exactly once for each action... I will take a look tomorrow. > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das >Assignee: Sergey Shelukhin > Fix For: hbase-10070 > > Attachments: 10634-1.txt > > -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10634) Multiget doesn't fully work
[ https://issues.apache.org/jira/browse/HBASE-10634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915389#comment-13915389 ] Devaraj Das commented on HBASE-10634: - I should mention that I was running the test on my laptop, I had two regionservers. The IT test by default would create three region replicas if run using the command I provided in the last comment. > Multiget doesn't fully work > --- > > Key: HBASE-10634 > URL: https://issues.apache.org/jira/browse/HBASE-10634 > Project: HBase > Issue Type: Sub-task >Reporter: Devaraj Das > Fix For: hbase-10070 > > Attachments: 10634-1.txt > > -- This message was sent by Atlassian JIRA (v6.1.5#6160)
