[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[ https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925514#comment-13925514 ] Hudson commented on HBASE-10651: FAILURE: Integrated in HBase-0.98 #215 (See [https://builds.apache.org/job/HBase-0.98/215/]) HBASE-10651 Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication (Honghua Feng) (stack: rev 1575606) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java > Fix incorrect handling of IE that restores current thread's interrupt status > within while/for loops in Replication > -- > > Key: HBASE-10651 > URL: https://issues.apache.org/jira/browse/HBASE-10651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Replication >Reporter: Feng Honghua >Assignee: Feng Honghua > Fix For: 0.98.1, 0.99.0 > > Attachments: HBASE-10651-trunk_v1.patch, HBASE-10651-trunk_v2.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[ https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925073#comment-13925073 ] Hudson commented on HBASE-10651: FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #111 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/111/]) HBASE-10651 Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication (Honghua Feng) (stack: rev 1575605) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java > Fix incorrect handling of IE that restores current thread's interrupt status > within while/for loops in Replication > -- > > Key: HBASE-10651 > URL: https://issues.apache.org/jira/browse/HBASE-10651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Replication >Reporter: Feng Honghua >Assignee: Feng Honghua > Fix For: 0.98.1, 0.99.0 > > Attachments: HBASE-10651-trunk_v1.patch, HBASE-10651-trunk_v2.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[ https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925048#comment-13925048 ] Hudson commented on HBASE-10651: SUCCESS: Integrated in HBase-TRUNK #4993 (See [https://builds.apache.org/job/HBase-TRUNK/4993/]) HBASE-10651 Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication (Honghua Feng) (stack: rev 1575605) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java > Fix incorrect handling of IE that restores current thread's interrupt status > within while/for loops in Replication > -- > > Key: HBASE-10651 > URL: https://issues.apache.org/jira/browse/HBASE-10651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Replication >Reporter: Feng Honghua >Assignee: Feng Honghua > Fix For: 0.98.1, 0.99.0 > > Attachments: HBASE-10651-trunk_v1.patch, HBASE-10651-trunk_v2.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[ https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925014#comment-13925014 ] Hudson commented on HBASE-10651: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #200 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/200/]) HBASE-10651 Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication (Honghua Feng) (stack: rev 1575606) * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java > Fix incorrect handling of IE that restores current thread's interrupt status > within while/for loops in Replication > -- > > Key: HBASE-10651 > URL: https://issues.apache.org/jira/browse/HBASE-10651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Replication >Reporter: Feng Honghua >Assignee: Feng Honghua > Fix For: 0.98.1, 0.99.0 > > Attachments: HBASE-10651-trunk_v1.patch, HBASE-10651-trunk_v2.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[ https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924782#comment-13924782 ] Feng Honghua commented on HBASE-10651: -- Ping for review, thanks :-) > Fix incorrect handling of IE that restores current thread's interrupt status > within while/for loops in Replication > -- > > Key: HBASE-10651 > URL: https://issues.apache.org/jira/browse/HBASE-10651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Replication >Reporter: Feng Honghua >Assignee: Feng Honghua > Attachments: HBASE-10651-trunk_v1.patch, HBASE-10651-trunk_v2.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[
https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920530#comment-13920530
]
Hadoop QA commented on HBASE-10651:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12632413/HBASE-10651-trunk_v2.patch
against trunk revision .
ATTACHMENT ID: 12632413
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8890//console
This message is automatically generated.
> Fix incorrect handling of IE that restores current thread's interrupt status
> within while/for loops in Replication
> --
>
> Key: HBASE-10651
> URL: https://issues.apache.org/jira/browse/HBASE-10651
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Replication
>Reporter: Feng Honghua
>Assignee: Feng Honghua
> Attachments: HBASE-10651-trunk_v1.patch, HBASE-10651-trunk_v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[ https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918865#comment-13918865 ] Feng Honghua commented on HBASE-10651: -- bq.How does going back to while to check if we need to terminate relate to setting interrupt on thread? isActive doesn't seem to check thread state. Yeah. Though I add interrupting replication thread in 'terminate' method after the line setting 'running' to false, we still need to add checking interrupt status in isActive() to make the overall logic complete/consistent, since replication thread can possibly be interrupted directly rather than by calling terminate() method from outside... > Fix incorrect handling of IE that restores current thread's interrupt status > within while/for loops in Replication > -- > > Key: HBASE-10651 > URL: https://issues.apache.org/jira/browse/HBASE-10651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Replication >Reporter: Feng Honghua >Assignee: Feng Honghua > Attachments: HBASE-10651-trunk_v1.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[ https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918295#comment-13918295 ] stack commented on HBASE-10651: --- [~fenghh] How does going back to while to check if we need to terminate relate to setting interrupt on thread? isActive doesn't seem to check thread state. > Fix incorrect handling of IE that restores current thread's interrupt status > within while/for loops in Replication > -- > > Key: HBASE-10651 > URL: https://issues.apache.org/jira/browse/HBASE-10651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Replication >Reporter: Feng Honghua >Assignee: Feng Honghua > Attachments: HBASE-10651-trunk_v1.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[ https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918240#comment-13918240 ] Nicolas Liochon commented on HBASE-10651: - I'm not totally sure here. Any opinion? > Fix incorrect handling of IE that restores current thread's interrupt status > within while/for loops in Replication > -- > > Key: HBASE-10651 > URL: https://issues.apache.org/jira/browse/HBASE-10651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Replication >Reporter: Feng Honghua >Assignee: Feng Honghua > Attachments: HBASE-10651-trunk_v1.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10651) Fix incorrect handling of IE that restores current thread's interrupt status within while/for loops in Replication
[ https://issues.apache.org/jira/browse/HBASE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917393#comment-13917393 ] Feng Honghua commented on HBASE-10651: -- # Directly go back to while() to check if need to terminate after receiving interruption # Make replication thread more responsive to the termination by replication manager by interrupting current thread in terminate() > Fix incorrect handling of IE that restores current thread's interrupt status > within while/for loops in Replication > -- > > Key: HBASE-10651 > URL: https://issues.apache.org/jira/browse/HBASE-10651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Replication >Reporter: Feng Honghua >Assignee: Feng Honghua > Attachments: HBASE-10651-trunk_v1.patch > > -- This message was sent by Atlassian JIRA (v6.1.5#6160)
