[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[ https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941593#comment-13941593 ] Hudson commented on HBASE-10781: SUCCESS: Integrated in HBase-TRUNK #5027 (See [https://builds.apache.org/job/HBase-TRUNK/5027/]) HBASE-10781 Remove hadoop-one-compat module and all references to hadoop1 -- ADDENDUM (stack: rev 1579544) * /hbase/trunk/dev-support/test-patch.sh Remove hadoop-one-compat module and all references to hadoop1 - Key: HBASE-10781 URL: https://issues.apache.org/jira/browse/HBASE-10781 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 0.99.0 Attachments: 10690.txt, 10690v2.txt, 10781-addendum.txt, 10781v3.txt Clean out hadoop1 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[
https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940359#comment-13940359
]
Hadoop QA commented on HBASE-10781:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12635507/10690v2.txt
against trunk revision .
ATTACHMENT ID: 12635507
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 24 new
or modified tests.
{color:red}-1 hadoop1.0{color}. The patch failed to compile against the
hadoop 1.0 profile.
Here is snippet of errors:
{code}{code}
{color:red}-1 hadoop1.1{color}. The patch failed to compile against the
hadoop 1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+These instructions are for building HBase 1.0.x. For building earlier
versions, the process is different. See this section
+paraNow, build the src tarball. This tarball is hadoop version
independent. It is just the pure src code and documentation without a
particular hadoop taint, etc.
+Add the varname-Prelease/varname profile when building; it
checks files for licenses and will fail the build if unlicensed files present.
+notetitlePoint Release Only/titleparaThe following step that creates a
new tag can be skipped since you've already created the point release
tag/para/note
+The last command above copies all artifacts up to a temporary staging apache
mvn repo in an 'open' state.
+ paraThe script filenamedev-support/make_rc.sh/filename
automates alot of the above listed release steps.
+ staging repository up in apache maven (human intervention is
needed here), the checking of
+ the produced artifacts to ensure they are 'good' -- e.g. undoing
the produced tarballs, eyeballing them to make
+ sure they look right then starting and checking all is running
properly -- and then the signing and pushing of
+paraNow lets get back to what is up in maven. Our artifacts should
be up in maven repository in the staging area
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9043//console
This message is automatically generated.
Remove hadoop-one-compat module and all references to hadoop1
-
Key: HBASE-10781
URL: https://issues.apache.org/jira/browse/HBASE-10781
Project: HBase
Issue Type: Sub-task
Reporter: stack
Assignee: stack
Fix For: 0.99.0
Attachments: 10690.txt, 10690v2.txt
Clean
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[ https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940842#comment-13940842 ] Elliott Clark commented on HBASE-10781: --- Are we expecting that hadoop will stop requiring us to do this kind of shimming (Hadoop 3.0 whenever it becomes a thing) ? or should we consider keeping the hadoop targeted build scripts ? Remove hadoop-one-compat module and all references to hadoop1 - Key: HBASE-10781 URL: https://issues.apache.org/jira/browse/HBASE-10781 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 0.99.0 Attachments: 10690.txt, 10690v2.txt Clean out hadoop1 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[ https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941052#comment-13941052 ] stack commented on HBASE-10781: --- [~eclark] The hadoop3 patch doesn't include a hadoop3-compat-module, HBASE-6581, as yet. We discussed adding one though IIRC because its all about changes in sync API. So I don't see us giving up your little compat 'system' yet. I got rid of the little build script because while it served a purpose, it is ugly. We can revive it if we need such a beast going forward (maven will be 'fixed' the next time we need this kind of facility -- smile). I'm testing out my little make-rc.sh changes to run against trunk.. The built tarball has some CLASSPATH issues. Trying to fix before commit. Remove hadoop-one-compat module and all references to hadoop1 - Key: HBASE-10781 URL: https://issues.apache.org/jira/browse/HBASE-10781 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 0.99.0 Attachments: 10690.txt, 10690v2.txt Clean out hadoop1 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[ https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941099#comment-13941099 ] Enis Soztutar commented on HBASE-10781: --- Yeah, we can keep the hadoop-compat modules, since I think some hadoop-2.x might also require a shim of its own even before 3.0. Remove hadoop-one-compat module and all references to hadoop1 - Key: HBASE-10781 URL: https://issues.apache.org/jira/browse/HBASE-10781 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 0.99.0 Attachments: 10690.txt, 10690v2.txt Clean out hadoop1 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[ https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941131#comment-13941131 ] Enis Soztutar commented on HBASE-10781: --- lgtm. Remove hadoop-one-compat module and all references to hadoop1 - Key: HBASE-10781 URL: https://issues.apache.org/jira/browse/HBASE-10781 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 0.99.0 Attachments: 10690.txt, 10690v2.txt, 10781v3.txt Clean out hadoop1 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[ https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941212#comment-13941212 ] Hudson commented on HBASE-10781: FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #123 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/123/]) HBASE-10781 Remove hadoop-one-compat module and all references to hadoop1 (stack: rev 1579449) * /hbase/trunk/dev-support/generate-hadoopX-poms.sh * /hbase/trunk/dev-support/make_rc.sh * /hbase/trunk/hbase-assembly/src/main/assembly/components.xml * /hbase/trunk/hbase-assembly/src/main/assembly/hadoop-one-compat.xml * /hbase/trunk/hbase-hadoop1-compat * /hbase/trunk/pom.xml * /hbase/trunk/src/main/docbkx/developer.xml Remove hadoop-one-compat module and all references to hadoop1 - Key: HBASE-10781 URL: https://issues.apache.org/jira/browse/HBASE-10781 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 0.99.0 Attachments: 10690.txt, 10690v2.txt, 10781v3.txt Clean out hadoop1 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[ https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941348#comment-13941348 ] Hudson commented on HBASE-10781: FAILURE: Integrated in HBase-TRUNK #5025 (See [https://builds.apache.org/job/HBase-TRUNK/5025/]) HBASE-10781 Remove hadoop-one-compat module and all references to hadoop1 (stack: rev 1579449) * /hbase/trunk/dev-support/generate-hadoopX-poms.sh * /hbase/trunk/dev-support/make_rc.sh * /hbase/trunk/hbase-assembly/src/main/assembly/components.xml * /hbase/trunk/hbase-assembly/src/main/assembly/hadoop-one-compat.xml * /hbase/trunk/hbase-hadoop1-compat * /hbase/trunk/pom.xml * /hbase/trunk/src/main/docbkx/developer.xml Remove hadoop-one-compat module and all references to hadoop1 - Key: HBASE-10781 URL: https://issues.apache.org/jira/browse/HBASE-10781 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 0.99.0 Attachments: 10690.txt, 10690v2.txt, 10781v3.txt Clean out hadoop1 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[
https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938887#comment-13938887
]
Hadoop QA commented on HBASE-10781:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12635247/10690.txt
against trunk revision .
ATTACHMENT ID: 12635247
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 24 new
or modified tests.
{color:red}-1 hadoop1.0{color}. The patch failed to compile against the
hadoop 1.0 profile.
Here is snippet of errors:
{code}{code}
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9030//console
This message is automatically generated.
Remove hadoop-one-compat module and all references to hadoop1
-
Key: HBASE-10781
URL: https://issues.apache.org/jira/browse/HBASE-10781
Project: HBase
Issue Type: Sub-task
Reporter: stack
Assignee: stack
Fix For: 0.99.0
Attachments: 10690.txt
Clean out hadoop1 references.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[ https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939905#comment-13939905 ] Enis Soztutar commented on HBASE-10781: --- Great. +1. My only concern is the same comment I left in HBASE-10691. Wondering whether keeping the hadoop-1 compilation support in test-patch.sh because of backporting patches will continue for bugs for some time. We have the jenkins builds for 0.98 and 0.96 which build with hadoop1, so it is just a convenience for developers at this point. Remove hadoop-one-compat module and all references to hadoop1 - Key: HBASE-10781 URL: https://issues.apache.org/jira/browse/HBASE-10781 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 0.99.0 Attachments: 10690.txt Clean out hadoop1 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10781) Remove hadoop-one-compat module and all references to hadoop1
[ https://issues.apache.org/jira/browse/HBASE-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939913#comment-13939913 ] stack commented on HBASE-10781: --- I'll commit this (after another pass on the doc -- its messy keeping different build instruction for 0.96-0.98) and if a pain, lets put back the h1 stuff. Thanks for review Enis. Remove hadoop-one-compat module and all references to hadoop1 - Key: HBASE-10781 URL: https://issues.apache.org/jira/browse/HBASE-10781 Project: HBase Issue Type: Sub-task Reporter: stack Assignee: stack Fix For: 0.99.0 Attachments: 10690.txt Clean out hadoop1 references. -- This message was sent by Atlassian JIRA (v6.2#6252)
