[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950497#comment-13950497 ] Hudson commented on HBASE-10788: FAILURE: Integrated in HBase-TRUNK #5047 (See [https://builds.apache.org/job/HBase-TRUNK/5047/]) HBASE-10788 Add 99th percentile of latency in PE (Liu Shaohui) (liangxie: rev 1582583) * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.99.0 >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff, > HBASE-10788-trunk-v3.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950298#comment-13950298 ] Liang Xie commented on HBASE-10788: --- Integrated into trunk, thanks all for review, thank you for the patch [~liushaohui] :) > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.99.0 >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Fix For: 0.99.0 > > Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff, > HBASE-10788-trunk-v3.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949817#comment-13949817 ] Nick Dimiduk commented on HBASE-10788: -- +1 > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.99.0 >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff, > HBASE-10788-trunk-v3.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[
https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949048#comment-13949048
]
Hadoop QA commented on HBASE-10788:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12637092/HBASE-10788-trunk-v3.diff
against trunk revision .
ATTACHMENT ID: 12637092
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 6
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.mapreduce.TestTableMapReduceBase.testMultiRegionTable(TestTableMapReduceBase.java:96)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9108//console
This message is automatically generated.
> Add 99th percentile of latency in PE
>
>
> Key: HBASE-10788
> URL: https://issues.apache.org/jira/browse/HBASE-10788
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 0.99.0
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff,
> HBASE-10788-trunk-v3.diff
>
>
> In production env, 99th percentile of latency is more important than the avg.
> The 99th percentile is helpful to measure the influence of GC, slow
> read/write of HDFS.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[
https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948910#comment-13948910
]
Liu Shaohui commented on HBASE-10788:
-
Sample output
{code}
2014-03-27 13:02:04,935 INFO [TestClient-2] hbase.PerformanceEvaluation:
RandomWriteTest latency log (ms), on 1024 measures
2014-03-27 13:02:04,935 INFO [TestClient-2] hbase.PerformanceEvaluation:
RandomWriteTest Min= 0.0
2014-03-27 13:02:04,935 INFO [TestClient-2] hbase.PerformanceEvaluation:
RandomWriteTest Avg= 0.0341796875
2014-03-27 13:02:04,936 INFO [TestClient-2] hbase.PerformanceEvaluation:
RandomWriteTest StdDev = 0.2722120941128983
2014-03-27 13:02:04,937 INFO [TestClient-2] hbase.PerformanceEvaluation:
RandomWriteTest 50th = 0.0
2014-03-27 13:02:04,938 INFO [TestClient-2] hbase.PerformanceEvaluation:
RandomWriteTest 95th = 0.0
2014-03-27 13:02:04,938 INFO [TestClient-2] hbase.PerformanceEvaluation:
RandomWriteTest 99th = 1.0
2014-03-27 13:02:04,939 INFO [TestClient-2] hbase.PerformanceEvaluation:
RandomWriteTest 99.9th = 6.8500136
2014-03-27 13:02:04,939 INFO [TestClient-2] hbase.PerformanceEvaluation:
RandomWriteTest Max= 7.0
{code}
> Add 99th percentile of latency in PE
>
>
> Key: HBASE-10788
> URL: https://issues.apache.org/jira/browse/HBASE-10788
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 0.99.0
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff,
> HBASE-10788-trunk-v3.diff
>
>
> In production env, 99th percentile of latency is more important than the avg.
> The 99th percentile is helpful to measure the influence of GC, slow
> read/write of HDFS.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[
https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948892#comment-13948892
]
Liu Shaohui commented on HBASE-10788:
-
[~ndimiduk]
{quote}
The thread name is not relevant in MR mode, and is redundant in your example
output above.
{code}
+ String metricName =
+ testName + "-Client-" + Thread.currentThread().getName() +
"-testRowTime";
{code}
{quote}
Adding thread name in the metric name is to distinguish metrics from different
threads in no mapred mode. The the thread names in the log are added by the
setStatus automatically and i will remove one.
Thanks for your review and I will update the patch later.
> Add 99th percentile of latency in PE
>
>
> Key: HBASE-10788
> URL: https://issues.apache.org/jira/browse/HBASE-10788
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 0.99.0
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff
>
>
> In production env, 99th percentile of latency is more important than the avg.
> The 99th percentile is helpful to measure the influence of GC, slow
> read/write of HDFS.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[
https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948242#comment-13948242
]
Nick Dimiduk commented on HBASE-10788:
--
nit: this patch has some extra ws. Please clean it up on commit.
The thread name is not relevant in MR mode, and is redundant in your example
output above.
{noformat}
+ String metricName =
+ testName + "-Client-" + Thread.currentThread().getName() +
"-testRowTime";
{noformat}
This will inaccurately count any results from tests that respect --sampleRate.
{noformat}
+long startTime = System.currentTimeMillis();
testRow(i);
+latency.update(System.currentTimeMillis() - startTime);
{noformat}
> Add 99th percentile of latency in PE
>
>
> Key: HBASE-10788
> URL: https://issues.apache.org/jira/browse/HBASE-10788
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 0.99.0
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff
>
>
> In production env, 99th percentile of latency is more important than the avg.
> The 99th percentile is helpful to measure the influence of GC, slow
> read/write of HDFS.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947564#comment-13947564 ] Liang Xie commented on HBASE-10788: --- +1. will commit tomorrow if no objection > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.99.0 >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946803#comment-13946803 ] stack commented on HBASE-10788: --- Patch lgtm (This is excellent) > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.99.0 >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946290#comment-13946290 ] Liang Xie commented on HBASE-10788: --- emmm... [~liushaohui] you forgot to click "Submit Patch", so it's not on the radar:) > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Affects Versions: 0.99.0 >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946287#comment-13946287 ] Liu Shaohui commented on HBASE-10788: - Would someone have time to review this patch? Thanks. > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff, HBASE-10788-trunk-v2.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940826#comment-13940826 ] Andrew Purtell commented on HBASE-10788: bq. Usually I find min, avg, 95th, 99th, and 99.9th percentiles, and max useful. Certainly average, max, and 95th are useful information in addition to higher percentiles, +1 > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940794#comment-13940794 ] Nick Dimiduk commented on HBASE-10788: -- Could be your use of a real metrics library is the right way to go. My version allocates arrays of doubles, which can become expensive. I'd also like to add a mixed-workload test, in which case it'll be good to isolate read from write metrics, etc. Maybe your use of the yammer metrics library will support this, and also help minimize memory footprint while maintaining statical significance of the results. If you're adding a new dependency, be sure to include the jar in the mapreduce job. Good on you [~liushaohui]. > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940227#comment-13940227 ] Liu Shaohui commented on HBASE-10788: - [~ndimiduk] Yes, I would like to add percentiles in the base class: Test and add all percentiles for all tests. Sorry for not noticing the percentiles code in the randomRead test. I will redo the patch based on HBASE-10007. > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940190#comment-13940190 ] Liang Xie commented on HBASE-10788: --- FYI, Nick have done a good latency job inside PE, see HBASE-10007. so your plan is to enhance it into more operation or? > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[
https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940186#comment-13940186
]
Nick Dimiduk commented on HBASE-10788:
--
PerfEval already has percentiles, at least for the randomRead test. Would you
like to add support to the other tests?
https://github.com/apache/hbase/blob/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java#L785-L795
{noformat}
LOG.info("randomRead latency log (ms), on " + times.length + "
measures");
LOG.info("99.% = " + ds.getPercentile(99.d));
LOG.info(" 99.999% = " + ds.getPercentile(99.999d));
LOG.info(" 99.99% = " + ds.getPercentile(99.99d));
LOG.info(" 99.9% = " + ds.getPercentile(99.9d));
LOG.info(" 99% = " + ds.getPercentile(99d));
LOG.info(" 95% = " + ds.getPercentile(95d));
LOG.info(" 90% = " + ds.getPercentile(90d));
LOG.info(" 80% = " + ds.getPercentile(80d));
LOG.info("Standard Deviation = " + ds.getStandardDeviation());
LOG.info("Mean = " + ds.getMean());
{noformat}
> Add 99th percentile of latency in PE
>
>
> Key: HBASE-10788
> URL: https://issues.apache.org/jira/browse/HBASE-10788
> Project: HBase
> Issue Type: Improvement
>Reporter: Liu Shaohui
>Assignee: Liu Shaohui
>Priority: Minor
> Attachments: HBASE-10788-trunk-v1.diff
>
>
> In production env, 99th percentile of latency is more important than the avg.
> The 99th percentile is helpful to measure the influence of GC, slow
> read/write of HDFS.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10788) Add 99th percentile of latency in PE
[ https://issues.apache.org/jira/browse/HBASE-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940182#comment-13940182 ] Lars Hofhansl commented on HBASE-10788: --- Usually I find min, avg, 95th, 99th, and 99.9th percentiles, and max useful. > Add 99th percentile of latency in PE > > > Key: HBASE-10788 > URL: https://issues.apache.org/jira/browse/HBASE-10788 > Project: HBase > Issue Type: Improvement >Reporter: Liu Shaohui >Assignee: Liu Shaohui >Priority: Minor > Attachments: HBASE-10788-trunk-v1.diff > > > In production env, 99th percentile of latency is more important than the avg. > The 99th percentile is helpful to measure the influence of GC, slow > read/write of HDFS. -- This message was sent by Atlassian JIRA (v6.2#6252)
