[jira] [Commented] (HBASE-10790) make assembly:single as default in pom.xml
[
https://issues.apache.org/jira/browse/HBASE-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942829#comment-13942829
]
Liu Shaohui commented on HBASE-10790:
-
[~stack]
Thanks. I didn't notice this problem.
Maybe we should not change the current build cmd and add more docs about how to
get a tarball in the section : https://hbase.apache.org/book/build.html.
make assembly:single as default in pom.xml
--
Key: HBASE-10790
URL: https://issues.apache.org/jira/browse/HBASE-10790
Project: HBase
Issue Type: Improvement
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Priority: Minor
Attachments: HBASE-10790-trunk-v1.diff
Now to compile a HBase tar release package, we should use
the cmd:
{code}
mvn clean package assembly:single
{code}, which is not convenient. We can make assembly:single as a default
option and run the assembly plugin in maven package phase. Then we can just
use the cmd {code} mvn clean package {code} to get a release package.
Other suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10790) make assembly:single as default in pom.xml
[
https://issues.apache.org/jira/browse/HBASE-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941443#comment-13941443
]
stack commented on HBASE-10790:
---
In hadoop, there is a dist profile and then you have to add a -Dtar to actually
get a tar ball. It is a different kind of cryptic to what we have now in
hbase. In hbase, our philosophy is you must call out what you want; i.e. you
say if you want the docs and if you want an assembly. We arrived here because
hooking up doc building or assembly as by-products of standard maven goals
makes simple checks like whether your change compiles excruciating as you must
wait on javadoc, etc (see Enis comment above). And then some tasks do not fit
mvn standard model when it a multi-module project as hbase is; for example the
javadoc aggregate goal which seemingly must be called out as explicit goal or
even the assembly if you want to include site/doc.
Is it that you just forget to add the assembly:single or is it that you think
the tar ball should always be produced [~liushaohui]? How much longer does it
take to make the tarball? If you include tarball as goal in package, can we
still include site and doc? Thanks.
make assembly:single as default in pom.xml
--
Key: HBASE-10790
URL: https://issues.apache.org/jira/browse/HBASE-10790
Project: HBase
Issue Type: Improvement
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Priority: Minor
Attachments: HBASE-10790-trunk-v1.diff
Now to compile a HBase tar release package, we should use
the cmd:
{code}
mvn clean package assembly:single
{code}, which is not convenient. We can make assembly:single as a default
option and run the assembly plugin in maven package phase. Then we can just
use the cmd {code} mvn clean package {code} to get a release package.
Other suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10790) make assembly:single as default in pom.xml
[
https://issues.apache.org/jira/browse/HBASE-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941486#comment-13941486
]
Liu Shaohui commented on HBASE-10790:
-
[~stack]
{quote}
Is it that you just forget to add the assembly:single or is it that you think
the tar ball should always be produced
{quote}
Yes, I think the tar ball should be produced in most times and using
assembly:single option to build tar ball is not direct.
{quote}
How much longer does it take to make the tarball?
{quote}
In my dev machine, it will take about 13s more to make the tarball.
{code}
time mvn clean package -DskipTests -1m10.656s
time mvn clean package assembly:single -DskipTests - 1m23.425s
{code}
make assembly:single as default in pom.xml
--
Key: HBASE-10790
URL: https://issues.apache.org/jira/browse/HBASE-10790
Project: HBase
Issue Type: Improvement
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Priority: Minor
Attachments: HBASE-10790-trunk-v1.diff
Now to compile a HBase tar release package, we should use
the cmd:
{code}
mvn clean package assembly:single
{code}, which is not convenient. We can make assembly:single as a default
option and run the assembly plugin in maven package phase. Then we can just
use the cmd {code} mvn clean package {code} to get a release package.
Other suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10790) make assembly:single as default in pom.xml
[
https://issues.apache.org/jira/browse/HBASE-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941877#comment-13941877
]
stack commented on HBASE-10790:
---
If we add the generation of tarball to package step, how we get the javadoc and
site doc into the tgz? We'd add a profile? Thanks.
make assembly:single as default in pom.xml
--
Key: HBASE-10790
URL: https://issues.apache.org/jira/browse/HBASE-10790
Project: HBase
Issue Type: Improvement
Reporter: Liu Shaohui
Assignee: Liu Shaohui
Priority: Minor
Attachments: HBASE-10790-trunk-v1.diff
Now to compile a HBase tar release package, we should use
the cmd:
{code}
mvn clean package assembly:single
{code}, which is not convenient. We can make assembly:single as a default
option and run the assembly plugin in maven package phase. Then we can just
use the cmd {code} mvn clean package {code} to get a release package.
Other suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10790) make assembly:single as default in pom.xml
[
https://issues.apache.org/jira/browse/HBASE-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941130#comment-13941130
]
Enis Soztutar commented on HBASE-10790:
---
I am not in favor of this, since install requires package, it would mean that
every mvn install would build the tarball. And even in my SSD MBP, it takes 40
sec to build the tarball.
Building the tarball is a much less frequent operation than mvn install (at
least in my daily development).
make assembly:single as default in pom.xml
--
Key: HBASE-10790
URL: https://issues.apache.org/jira/browse/HBASE-10790
Project: HBase
Issue Type: Improvement
Reporter: Liu Shaohui
Priority: Minor
Attachments: HBASE-10790-trunk-v1.diff
Now to compile a HBase tar release package, we should use
the cmd:
{code}
mvn clean package assembly:single
{code}, which is not convenient. We can make assembly:single as a default
option and run the assembly plugin in maven package phase. Then we can just
use the cmd {code} mvn clean package {code} to get a release package.
Other suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10790) make assembly:single as default in pom.xml
[
https://issues.apache.org/jira/browse/HBASE-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941330#comment-13941330
]
Liu Shaohui commented on HBASE-10790:
-
[~enis]
The tarball is built in the maven package phase in HBase 0.94, so i would like
to keep the behavior consistent in trunk.
{quote}
Building the tarball is a much less frequent operation than mvn install
{quote}
Maybe we can add a new maven profile named dist like that we did in Hadoop
project. When we want to build a tarball, we use
{code} mvn clean package -Pdist {code}
make assembly:single as default in pom.xml
--
Key: HBASE-10790
URL: https://issues.apache.org/jira/browse/HBASE-10790
Project: HBase
Issue Type: Improvement
Reporter: Liu Shaohui
Priority: Minor
Attachments: HBASE-10790-trunk-v1.diff
Now to compile a HBase tar release package, we should use
the cmd:
{code}
mvn clean package assembly:single
{code}, which is not convenient. We can make assembly:single as a default
option and run the assembly plugin in maven package phase. Then we can just
use the cmd {code} mvn clean package {code} to get a release package.
Other suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10790) make assembly:single as default in pom.xml
[
https://issues.apache.org/jira/browse/HBASE-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941358#comment-13941358
]
Enis Soztutar commented on HBASE-10790:
---
We have a release profile, but it does run rat as well. A dist profile seems
acceptable.
make assembly:single as default in pom.xml
--
Key: HBASE-10790
URL: https://issues.apache.org/jira/browse/HBASE-10790
Project: HBase
Issue Type: Improvement
Reporter: Liu Shaohui
Priority: Minor
Attachments: HBASE-10790-trunk-v1.diff
Now to compile a HBase tar release package, we should use
the cmd:
{code}
mvn clean package assembly:single
{code}, which is not convenient. We can make assembly:single as a default
option and run the assembly plugin in maven package phase. Then we can just
use the cmd {code} mvn clean package {code} to get a release package.
Other suggestions are welcomed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
