[jira] [Commented] (HBASE-10838) AcessController covering permission check checking only one Cell's permission
[ https://issues.apache.org/jira/browse/HBASE-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947882#comment-13947882 ] Hadoop QA commented on HBASE-10838: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636903/HBASE-10838.patch against trunk revision . ATTACHMENT ID: 12636903 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 6 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.security.access.TestAccessController {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestTableMapReduceBase.testMultiRegionTable(TestTableMapReduceBase.java:96) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9096//console This message is automatically generated. AcessController covering permission check checking only one Cell's permission - Key: HBASE-10838 URL: https://issues.apache.org/jira/browse/HBASE-10838 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Priority: Critical Fix For: 0.99.0, 0.98.2 Attachments: HBASE-10838.patch {code} get.setMaxResultsPerColumnFamily(1); // Hold down memory use on wide rows {code} Setting this returns only one cell irrespective of the number of versions /qualifiers in a family. Instead we should have used the limit option to next() call -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10838) AcessController covering permission check checking only one Cell's permission
[ https://issues.apache.org/jira/browse/HBASE-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948016#comment-13948016 ] Hadoop QA commented on HBASE-10838: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636922/HBASE-10838_V2.patch against trunk revision . ATTACHMENT ID: 12636922 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 6 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestRegionPlacement Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9097//console This message is automatically generated. AcessController covering permission check checking only one Cell's permission - Key: HBASE-10838 URL: https://issues.apache.org/jira/browse/HBASE-10838 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Priority: Critical Fix For: 0.99.0, 0.98.2 Attachments: HBASE-10838.patch, HBASE-10838_V2.patch {code} get.setMaxResultsPerColumnFamily(1); // Hold down memory use on wide rows {code} Setting this returns only one cell irrespective of the number of versions /qualifiers in a family. Instead we should have used the limit option to next() call -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-10838) AcessController covering permission check checking only one Cell's permission
[ https://issues.apache.org/jira/browse/HBASE-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948065#comment-13948065 ] Andrew Purtell commented on HBASE-10838: bq. Instead we should have used the limit option to next() call +1 Will commit this shortly and spin RC2 AcessController covering permission check checking only one Cell's permission - Key: HBASE-10838 URL: https://issues.apache.org/jira/browse/HBASE-10838 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.98.0 Reporter: Anoop Sam John Assignee: Anoop Sam John Priority: Critical Fix For: 0.99.0, 0.98.2 Attachments: HBASE-10838.patch, HBASE-10838_V2.patch {code} get.setMaxResultsPerColumnFamily(1); // Hold down memory use on wide rows {code} Setting this returns only one cell irrespective of the number of versions /qualifiers in a family. Instead we should have used the limit option to next() call -- This message was sent by Atlassian JIRA (v6.2#6252)