[jira] [Commented] (HBASE-10892) Add support for globs in user_permission
[
https://issues.apache.org/jira/browse/HBASE-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981246#comment-13981246
]
Matteo Bertozzi commented on HBASE-10892:
-
+1 for me
Add support for globs in user_permission
Key: HBASE-10892
URL: https://issues.apache.org/jira/browse/HBASE-10892
Project: HBase
Issue Type: Improvement
Components: shell
Affects Versions: 0.99.0
Reporter: Esteban Gutierrez
Assignee: Esteban Gutierrez
Fix For: 0.99.0, 0.98.2
Attachments: HBASE-10892.v0.diff, HBASE-10892.v1.patch
It would be nice for {{user_permission}} to show all the permissions for all
the tables or a subset of tables if a glob (regex) is provided.
{code}
hbase user_permission '*'
User Table,Family,Qualifier:Permission
esteban x,,: [Permission:
actions=READ,WRITE,EXEC,CREATE,ADMIN]
hbase1y,,: [Permission:
actions=READ,WRITE]
hbase2z,,: [Permission:
actions=READ,WRITE]
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10892) Add support for globs in user_permission
[
https://issues.apache.org/jira/browse/HBASE-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980527#comment-13980527
]
Andrew Purtell commented on HBASE-10892:
[~esteban] if you do want to address those two points from Matteo then this
would be good to go I'd say.
Add support for globs in user_permission
Key: HBASE-10892
URL: https://issues.apache.org/jira/browse/HBASE-10892
Project: HBase
Issue Type: Improvement
Components: shell
Affects Versions: 0.99.0
Reporter: Esteban Gutierrez
Assignee: Esteban Gutierrez
Attachments: HBASE-10892.v0.diff
It would be nice for {{user_permission}} to show all the permissions for all
the tables or a subset of tables if a glob (regex) is provided.
{code}
hbase user_permission '*'
User Table,Family,Qualifier:Permission
esteban x,,: [Permission:
actions=READ,WRITE,EXEC,CREATE,ADMIN]
hbase1y,,: [Permission:
actions=READ,WRITE]
hbase2z,,: [Permission:
actions=READ,WRITE]
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10892) Add support for globs in user_permission
[
https://issues.apache.org/jira/browse/HBASE-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980678#comment-13980678
]
Hadoop QA commented on HBASE-10892:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12641858/HBASE-10892.v1.patch
against trunk revision .
ATTACHMENT ID: 12641858
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ raise(ArgumentError, Can't find a namespace:
#{namespace_name}) unless namespace_exists?(namespace_name)
+ family = (value.getFamily != nil) ?
org.apache.hadoop.hbase.util.Bytes::toStringBinary(value.getFamily) : ''
+ qualifier = (value.getQualifier != nil) ?
org.apache.hadoop.hbase.util.Bytes::toStringBinary(value.getQualifier) : ''
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9395//console
This message is automatically generated.
Add support for globs in user_permission
Key: HBASE-10892
URL: https://issues.apache.org/jira/browse/HBASE-10892
Project: HBase
Issue Type: Improvement
Components: shell
Affects Versions: 0.99.0
Reporter: Esteban Gutierrez
Assignee: Esteban Gutierrez
Attachments: HBASE-10892.v0.diff, HBASE-10892.v1.patch
It would be nice for {{user_permission}} to show all the permissions for all
the tables or a subset of tables if a glob (regex) is provided.
{code}
hbase user_permission '*'
User Table,Family,Qualifier:Permission
esteban x,,: [Permission:
actions=READ,WRITE,EXEC,CREATE,ADMIN]
hbase1y,,: [Permission:
actions=READ,WRITE]
hbase2z,,: [Permission:
actions=READ,WRITE]
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10892) Add support for globs in user_permission
[
https://issues.apache.org/jira/browse/HBASE-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13957236#comment-13957236
]
Matteo Bertozzi commented on HBASE-10892:
-
looks ok to me, (I've also tried it a bit)
but there are a couple of things I'm not sure about
I think that the glob only for all tables may be confusing,
because then you can't do tableName* you must use tableName.*
but I'm ok having it as a special all tables case.
admin.getTableNames() is and was committed as Deprecated. I know that is used
in other places, but we should decide if we want to use that for new code or
not and later replace it where is used.
Add support for globs in user_permission
Key: HBASE-10892
URL: https://issues.apache.org/jira/browse/HBASE-10892
Project: HBase
Issue Type: Improvement
Components: shell
Affects Versions: 0.99.0
Reporter: Esteban Gutierrez
Assignee: Esteban Gutierrez
Attachments: HBASE-10892.v0.diff
It would be nice for {{user_permission}} to show all the permissions for all
the tables or a subset of tables if a glob (regex) is provided.
{code}
hbase user_permission '*'
User Table,Family,Qualifier:Permission
esteban x,,: [Permission:
actions=READ,WRITE,EXEC,CREATE,ADMIN]
hbase1y,,: [Permission:
actions=READ,WRITE]
hbase2z,,: [Permission:
actions=READ,WRITE]
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10892) Add support for globs in user_permission
[
https://issues.apache.org/jira/browse/HBASE-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13957250#comment-13957250
]
Esteban Gutierrez commented on HBASE-10892:
---
{quote}
I think that the glob only for all tables may be confusing,
because then you can't do tableName* you must use tableName.*
but I'm ok having it as a special all tables case.
{quote}
I can add the missing . to the regex so it can work both ways.
{quote}
admin.getTableNames() is and was committed as Deprecated. I know that is used
in other places, but we should decide if we want to use that for new code or
not and later replace it where is used.
{quote}
I can add another implementation without {{admin.getTableNames()}} will that
work [~mbertozzi]?
Add support for globs in user_permission
Key: HBASE-10892
URL: https://issues.apache.org/jira/browse/HBASE-10892
Project: HBase
Issue Type: Improvement
Components: shell
Affects Versions: 0.99.0
Reporter: Esteban Gutierrez
Assignee: Esteban Gutierrez
Attachments: HBASE-10892.v0.diff
It would be nice for {{user_permission}} to show all the permissions for all
the tables or a subset of tables if a glob (regex) is provided.
{code}
hbase user_permission '*'
User Table,Family,Qualifier:Permission
esteban x,,: [Permission:
actions=READ,WRITE,EXEC,CREATE,ADMIN]
hbase1y,,: [Permission:
actions=READ,WRITE]
hbase2z,,: [Permission:
actions=READ,WRITE]
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-10892) Add support for globs in user_permission
[
https://issues.apache.org/jira/browse/HBASE-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13957280#comment-13957280
]
Hadoop QA commented on HBASE-10892:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12638167/HBASE-10892.v0.diff
against trunk revision .
ATTACHMENT ID: 12638167
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ raise(ArgumentError, Can't find a namespace:
#{namespace_name}) unless namespace_exists?(namespace_name)
+ family = (value.getFamily != nil) ?
org.apache.hadoop.hbase.util.Bytes::toStringBinary(value.getFamily) : ''
+ qualifier = (value.getQualifier != nil) ?
org.apache.hadoop.hbase.util.Bytes::toStringBinary(value.getQualifier) : ''
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS
org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9167//console
This message is automatically generated.
Add support for globs in user_permission
Key: HBASE-10892
URL: https://issues.apache.org/jira/browse/HBASE-10892
Project: HBase
Issue Type: Improvement
Components: shell
Affects Versions: 0.99.0
Reporter: Esteban Gutierrez
Assignee: Esteban Gutierrez
Attachments: HBASE-10892.v0.diff
It would be nice for {{user_permission}} to show all the permissions for all
the tables or a subset of tables if a glob (regex) is provided.
{code}
hbase user_permission '*'
User Table,Family,Qualifier:Permission
esteban x,,: [Permission:
actions=READ,WRITE,EXEC,CREATE,ADMIN]
hbase1y,,: [Permission:
actions=READ,WRITE]
hbase2z,,: [Permission:
actions=READ,WRITE]
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
